Bugzilla – Attachment 75944 Details for
Bug 20794
Don't show holds tab when user doesn't have circulate_remaining_permissions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20794: Hide holds tab on details when user lacks circulate_remaining_permissions
0001-Bug-20794-Hide-holds-tab-on-details-when-user-lacks-.patch (text/plain), 2.55 KB, created by
Amit Gupta
on 2018-06-11 09:21:17 UTC
(
hide
)
Description:
Bug 20794: Hide holds tab on details when user lacks circulate_remaining_permissions
Filename:
MIME Type:
Creator:
Amit Gupta
Created:
2018-06-11 09:21:17 UTC
Size:
2.55 KB
patch
obsolete
>From 49c57f5d976d748d400745d2cdfb6d03c35a6bcb Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 20 May 2018 04:23:47 +0200 >Subject: [PATCH] Bug 20794: Hide holds tab on details when user lacks > circulate_remaining_permissions > >If a user doesn't have circulate_remaining permissions, but has borrowers: >- checkouts tab is hidden >- details tab is visible >- holds tab on details is visible, but results in an error > >The problem is that the svc/holds script requires circulate_remaining_permissions. > >To test: >- Create 2 staff users with and without circulate_remaining_permissions > Both need borrowers permission >- Go to the details tab in a patron's account who has holds >- Verify that you get a datatables error for the staff patron without > circulate_remaining_permissions >- Apply patch >- Verify that now the holds tab is no longer displayed for this patron > >Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >index 881fb45..7a3ed75 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >@@ -412,6 +412,7 @@ > <li><a href="#relatives-issues" id="relatives-issues-tab">Relatives' checkouts</a></li> > [% END %] > <li><a href="#finesandcharges">Fines & Charges</a></li> >+ [% IF ( CAN_user_circulate_circulate_remaining_permissions ) %] > <li> > [% IF ( holds_count ) %] > <a href="#reserves" id="holds-tab">[% holds_count %] Hold(s)</a> >@@ -419,6 +420,7 @@ > <a href="#reserves" id="holds-tab">0 Holds</a> > [% END %] > </li> >+ [% END %] > [% IF Koha.Preference('ArticleRequests') %] > <li> > <a href="#article-requests" id="article-requests-tab"> [% patron.article_requests_current.count %] Article requests</a> >@@ -478,6 +480,7 @@ > > [% INCLUDE borrower_debarments.inc %] > >+[% IF ( CAN_user_circulate_circulate_remaining_permissions ) %] > <div id="reserves"> > [% IF ( holds_count ) %] > <form action="/cgi-bin/koha/reserve/modrequest.pl" method="post"> >@@ -530,7 +533,7 @@ > > [% ELSE %]<p>Patron has nothing on hold.</p>[% END %] > </div> >- >+[% END %] > > [% IF Koha.Preference('ArticleRequests') %] > [% INCLUDE 'patron-article-requests.inc' %] >-- >2.7.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20794
:
75447
|
75944
|
76174