Bugzilla – Attachment 75966 Details for
Bug 20911
Search history page forms use 'GET' and this limits the number of entries that can be submitted
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20911: Use 'POST' to submit search history forms
Bug-20911-Use-POST-to-submit-search-history-forms.patch (text/plain), 5.84 KB, created by
Jesse Maseto
on 2018-06-11 16:11:00 UTC
(
hide
)
Description:
Bug 20911: Use 'POST' to submit search history forms
Filename:
MIME Type:
Creator:
Jesse Maseto
Created:
2018-06-11 16:11:00 UTC
Size:
5.84 KB
patch
obsolete
>From a0662db05b350df352444f6f9c2baad0ad1db603 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 11 Jun 2018 15:28:19 +0000 >Subject: [PATCH] Bug 20911: Use 'POST' to submit search history forms > >To test: >1 - Enable EnableOpacSearchHistory and EnableSearchHistory >2 - Do some searches >3 - View your search history in staff/opac >4 - Confirm you can delete single or multiple rows >5 - Confirm other page functionality has not changed > >Signed-off-by: Ed Veal <eveal@mckinneytexas.org> >--- > .../intranet-tmpl/prog/en/modules/catalogue/search-history.tt | 8 ++++---- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt >index 43a9bfa..a69e7a2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt >@@ -31,7 +31,7 @@ > <div id="biblio_tab"> > [% IF ( current_biblio_searches ) %] > <h2>Current session</h2> >- <form action="/cgi-bin/koha/catalogue/search-history.pl" method="get"> >+ <form action="/cgi-bin/koha/catalogue/search-history.pl" method="post"> > <div class="selections-toolbar"> > <a class="CheckAll" href="#"><i class="fa fa-check"></i> Select all visible rows</a> > <span class="sep">|</span> >@@ -68,7 +68,7 @@ > > [% IF ( previous_biblio_searches ) %] > <h2>Previous sessions</h2> >- <form action="/cgi-bin/koha/catalogue/search-history.pl" method="get"> >+ <form action="/cgi-bin/koha/catalogue/search-history.pl" method="post"> > <div class="selections-toolbar"> > <a class="CheckAll" href="#"><i class="fa fa-check"></i> Select all visible rows</a> > <span class="sep">|</span> >@@ -111,7 +111,7 @@ > <div id="authority_tab"> > [% IF ( current_authority_searches ) %] > <h2>Current session</h2> >- <form action="/cgi-bin/koha/catalogue/search-history.pl" method="get"> >+ <form action="/cgi-bin/koha/catalogue/search-history.pl" method="post"> > <div class="selections-toolbar"> > <a class="CheckAll" href="#"><i class="fa fa-check"></i> Select all visible rows</a> > <span class="sep">|</span> >@@ -148,7 +148,7 @@ > > [% IF ( previous_authority_searches ) %] > <h2>Previous sessions</h2> >- <form action="/cgi-bin/koha/catalogue/search-history.pl" method="get"> >+ <form action="/cgi-bin/koha/catalogue/search-history.pl" method="post"> > <div class="selections-toolbar"> > <a class="CheckAll" href="#"><i class="fa fa-check"></i> Select all visible rows</a> > <span class="sep">|</span> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt >index a2a774d..e146f76 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt >@@ -44,7 +44,7 @@ > <div id="current_biblio"> > [% IF ( current_biblio_searches ) %] > <h2>Current session</h2> >- <form action="/cgi-bin/koha/opac-search-history.pl" method="get"> >+ <form action="/cgi-bin/koha/opac-search-history.pl" method="post"> > <div class="selections-toolbar toolbar"> > <a class="CheckAll" href="#">Select all</a> > <a class="CheckNone" href="#">Clear all</a> >@@ -83,7 +83,7 @@ > <div id="previous_biblio"> > [% IF ( previous_biblio_searches ) %] > <h2>Previous sessions</h2> >- <form action="/cgi-bin/koha/opac-search-history.pl" method="get"> >+ <form action="/cgi-bin/koha/opac-search-history.pl" method="post"> > <div class="selections-toolbar toolbar"> > <a class="CheckAll" href="#">Select all</a> > <a class="CheckNone" href="#">Clear all</a> >@@ -129,7 +129,7 @@ > <div id="authority_tab"> > [% IF ( current_authority_searches ) %] > <h2>Current session</h2> >- <form action="/cgi-bin/koha/opac-search-history.pl" method="get"> >+ <form action="/cgi-bin/koha/opac-search-history.pl" method="post"> > <div class="selections-toolbar toolbar"> > <a class="CheckAll" href="#">Select all</a> > <a class="CheckNone" href="#">Clear all</a> >@@ -166,7 +166,7 @@ > > [% IF ( previous_authority_searches ) %] > <h2>Previous sessions</h2> >- <form action="/cgi-bin/koha/opac-search-history.pl" method="get"> >+ <form action="/cgi-bin/koha/opac-search-history.pl" method="post"> > <div class="selections-toolbar toolbar"> > <a class="CheckAll" href="#">Select all</a> > <a class="CheckNone" href="#">Clear all</a> >-- >2.1.4
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=75966">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20911
:
75962
|
75966
|
76002