Attachment 76020 Details for Bug 20923 – Bug 20923: Fix usage of grep

[patch] Bug 20923: Fix usage of grep

Bug-20923-Fix-usage-of-grep.patch (text/plain), 1.64 KB, created by Andrew Isherwood on 2018-06-13 09:16:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Isherwood

Created: 2018-06-13 09:16:19 UTC

Size: 1.64 KB

patch

obsolete

>From 1be80f42df982f806606da722977a20351ac907a Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Wed, 13 Jun 2018 10:14:24 +0100
>Subject: [PATCH] Bug 20923: Fix usage of grep
>
>This patch implements the fix described in the bug description. It is
>impossible to test without the work that will be added to bug 20917.
>Therefore a dependency will be added for that bug and a test plan will
>be added here when that work is done.
>---
> Koha/Illrequest.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm
>index 99b97bdbe4..748e9b269f 100644
>--- a/Koha/Illrequest.pm
>+++ b/Koha/Illrequest.pm
>@@ -372,7 +372,7 @@ sub _status_graph_union {
>         $status_graph->{$backend_status_key} = $backend_status;
>         # Update all core methods' next_actions.
>         foreach my $prev_action ( @{$backend_status->{prev_actions}} ) {
>-            if ( grep $prev_action, @core_status_ids ) {
>+            if ( grep /^$prev_action$/, @core_status_ids ) {
>                 my @next_actions =
>                      @{$status_graph->{$prev_action}->{next_actions}};
>                 push @next_actions, $backend_status_key;
>@@ -382,7 +382,7 @@ sub _status_graph_union {
>         }
>         # Update all core methods' prev_actions
>         foreach my $next_action ( @{$backend_status->{next_actions}} ) {
>-            if ( grep $next_action, @core_status_ids ) {
>+            if ( grep /^$next_action$/, @core_status_ids ) {
>                 my @prev_actions =
>                      @{$status_graph->{$next_action}->{prev_actions}};
>                 push @prev_actions, $backend_status_key;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20923: 76020