Bugzilla – Attachment 76061 Details for
Bug 20285
Lost item refund won't always pay down lost item fee first
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20285: Lost item refund won't always pay down lost item fee first
Bug-20285-Lost-item-refund-wont-always-pay-down-lo.patch (text/plain), 1.64 KB, created by
Jonathan Druart
on 2018-06-14 14:59:11 UTC
(
hide
)
Description:
Bug 20285: Lost item refund won't always pay down lost item fee first
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-06-14 14:59:11 UTC
Size:
1.64 KB
patch
obsolete
>From 0d764dcbafcb91e4a1fd01fcf233977f5ede1889 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatetsolutions.com> >Date: Fri, 23 Feb 2018 08:44:45 -0500 >Subject: [PATCH] Bug 20285: Lost item refund won't always pay down lost item > fee first > >Due to a simple typo, the accountline passed to Koha::Account::pay from _FixAccountForLostAndReturned is not used. That means that the credit for the lost item fee may be applied to other fees before it is used on the lost fee itself. > >Test Plan: >1) Find a patron with existing fines >2) Ensure your settings will charge patrons for lost items >3) Check out an item to a patron with existing fees that need paid >4) Mark the item lost, charging the lost item fee >5) Return the item >6) Note the fee was refunded, but it paid down earlier fines first, > and not the lost item fee first >7) Apply this patch set >8) Repeat steps 1 - 5 >9) Note the lost item fee is the first fee to be paid off by the lost > item fee refund > >Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> >Followed the test plan and it works as expected. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/Circulation.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 6aada15eba..8e1bdc49fc 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2412,7 +2412,7 @@ sub _FixAccountForLostAndReturned { > description => "Item Returned " . $item_id, > account_type => 'CR', > offset_type => 'Lost Item Return', >- accounlines => [$accountline], >+ lines => [$accountline], > > } > ); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20285
:
72122
|
72123
|
75936
|
76060
| 76061