Attachment 76096 Details for Bug 20952 – Bug 20861: Correct EDI permissions on EDI messsages

[patch] Bug 20861: Correct EDI permissions on EDI messsages

Bug-20861-Correct-EDI-permissions-on-EDI-messsages.patch (text/plain), 2.35 KB, created by Nightly Build Bot on 2018-06-15 12:26:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nightly Build Bot

Created: 2018-06-15 12:26:07 UTC

Size: 2.35 KB

patch

obsolete

>From 9c5aa046e72ed785cbbadf4fbbee55072f7fc9ba Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sun, 3 Jun 2018 10:09:23 +0200
>Subject: [PATCH] Bug 20861: Correct EDI permissions on EDI messsages
>
>The permission for EDI is edi_manage, but 2 pages asked
>for manage_edi, allowing users not to access those.
>
>To test:
>- Add edi_manage to your permissions
>- Try to access the EDIFACT messages from the
>  acq start page
>- Verify it doesn't work
>- Apply patch and try again
>- You should be able to access the page now
>- Try to access the other page directly (if you don't
>  have EDI data):
>  /cgi-bin/koha/acqui/edimsg.pl
>- Verify you can access the page and don't get a
>  permission error
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>(cherry picked from commit 7883b19de5f24551b36bf29133b04bc71ad4d56a)
>Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
>(cherry picked from commit cbeed6cf3db342e025b4d837ab135136d39a140e)
>Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
>
>https://bugs.koha-community.org/show_bug.cgi?id=20952
>---
> acqui/edifactmsgs.pl | 2 +-
> acqui/edimsg.pl      | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/acqui/edifactmsgs.pl b/acqui/edifactmsgs.pl
>index 608eaff0a9..effa918c1e 100755
>--- a/acqui/edifactmsgs.pl
>+++ b/acqui/edifactmsgs.pl
>@@ -32,7 +32,7 @@ my ( $template, $loggedinuser, $cookie, $userflags ) = get_template_and_user(
>         query           => $q,
>         type            => 'intranet',
>         authnotrequired => 0,
>-        flagsrequired   => { acquisition => 'manage_edi' },
>+        flagsrequired   => { acquisition => 'edi_manage' },
>         debug           => 1,
>     }
> );
>diff --git a/acqui/edimsg.pl b/acqui/edimsg.pl
>index c3547f025b..122b95a177 100755
>--- a/acqui/edimsg.pl
>+++ b/acqui/edimsg.pl
>@@ -32,7 +32,7 @@ my ( $template, $loggedinuser, $cookie, $userflags ) = get_template_and_user(
>         query           => $q,
>         type            => 'intranet',
>         authnotrequired => 0,
>-        flagsrequired   => { acquisition => 'manage_edi' },
>+        flagsrequired   => { acquisition => 'edi_manage' },
>         debug           => 1,
>     }
> );
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20952: 76096 | 82719 | 83049 | 83050 | 83391 | 83394 | 87241 | 102044