Attachment 76119 Details for Bug 19970 – Bug 19970: (17.11.x) Revise change of bug 19413 to work better for translations

[patch] Bug 19970: (17.11.x) Revise change of bug 19413 to work better for translations

Bug-19970-1711x-Revise-change-of-bug-19413-to-work.patch (text/plain), 2.85 KB, created by Owen Leonard on 2018-06-18 12:06:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2018-06-18 12:06:41 UTC

Size: 2.85 KB

patch

obsolete

>From 9047e5d3049d76f35c91796480429aaaea90ba60 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 18 Jun 2018 12:05:06 +0000
>Subject: [PATCH] Bug 19970: (17.11.x) Revise change of bug 19413 to work
> better for translations
>
>This patch changes how the submit and cancel buttons appear in the MARC
>008 plugin window. The controls are now displayed as buttons in a
>floating toolbar.
>
>To test you must have MARC tag 008 configured to use the
>marc21_field_008.pl plugin.
>
>- Apply the patch and open an existing or blank record in cataloging.
>- Click the plugin link next to tag 008 to trigger the popup window.
>- Confirm that "Save" and "Cancel" appear correctly in a toolbar.
>- Scroll down the page to confirm that the toolbar "sticks" to the top
>  of the window.
>- Confirm that the "Save" and "Cancel" buttons work correctly.
>---
> .../cataloguing/value_builder/marc21_field_008.tt    | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_field_008.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_field_008.tt
>index 172549f..dd0396ff 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_field_008.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_field_008.tt
>@@ -1,9 +1,18 @@
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Koha &rsaquo; Cataloging &rsaquo; 008 builder</title>
> [% INCLUDE 'doc-head-close.inc' %]
>-
>+<script type="text/javascript" src="[% interface %]/lib/jquery/plugins/jquery.fixFloat.js"></script>
> <script type="text/javascript" src='[% interface %]/[% theme %]/js/xmlControlfield.js'></script>
> <script type="text/javascript">
>+
>+    $(document).ready(function(){
>+        $('#toolbar').fixFloat();
>+        $(".close_window").on("click", function(e){
>+            e.preventDefault();
>+            window.close();
>+        });
>+    });
>+
>     var objXmlControlField;
>     var tr_result;
>     var h4_result;
>@@ -47,7 +56,14 @@
> <h4 id="h4_result">&quot;[% result %]&quot;</h4>
> 
> <form name="f_pop" id="f_pop" onsubmit="report()" action="">
>-<fieldset class="action" id="fixedlengthbuilderaction"><input type="submit" value="OK" /> <a href="#" class="cancel close">Cancel</a></fieldset>
>+    <div id="toolbar">
>+        <div class="btn-group">
>+            <button type="submit" class="btn btn-default btn-sm"><i class="fa fa-save"></i> Save</button>
>+        </div>
>+        <div class="btn-group">
>+            <button type="button" class="btn btn-default btn-sm close_window"><i class="fa fa-remove"></i> Cancel</button>
>+        </div>
>+    </div>
> <input type="hidden" name="plugin_name" value="marc21_field_008.pl" />
> <input type="hidden" id="[% index %]" name="index" value="[% index %]" />
> <input type="hidden" name="result" id="result" value="[% result %]" />
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 19970: 70481 | 75707 | 75935 | 76070 | 76118 | 76119