Bugzilla – Attachment 76226 Details for
Bug 20879
Shibboleth in combination with LDAP as an alternative no longer works
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20879: Fix regression in shibboleth when ldap enabled
Bug-20879-Fix-regression-in-shibboleth-when-ldap-e.patch (text/plain), 862 bytes, created by
Nick Clemens (kidclamp)
on 2018-06-21 10:10:19 UTC
(
hide
)
Description:
Bug 20879: Fix regression in shibboleth when ldap enabled
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2018-06-21 10:10:19 UTC
Size:
862 bytes
patch
obsolete
>From 3dd69aa428e52947533778762d7f1a6324ed2b76 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 21 Jun 2018 08:28:08 +0100 >Subject: [PATCH] Bug 20879: Fix regression in shibboleth when ldap enabled > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > C4/Auth.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 04584a9..43e4ad0 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -1772,7 +1772,7 @@ sub checkpw { > > if ( $patron and $patron->account_locked ) { > # Nothing to check, account is locked >- } elsif ($ldap) { >+ } elsif ($ldap && defined($password)) { > $debug and print STDERR "## checkpw - checking LDAP\n"; > my ( $retval, $retcard, $retuserid ) = checkpw_ldap(@_); # EXTERNAL AUTH > if ( $retval == 1 ) { >-- >2.1.4
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=76226">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20879
:
76220
| 76226