Attachment 76234 Details for Bug 20975 – AutoEscaping - Do not escape using .raw

[patch] AutoEscaping - Do not escape using .raw

AutoEscaping---Do-not-escape-using-raw.patch (text/plain), 1.51 KB, created by Jonathan Druart on 2018-06-21 14:04:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-06-21 14:04:05 UTC

Size: 1.51 KB

patch

obsolete

>From d4868a7e92f103f2df6714dfb09b83280f08a595 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 20 Jun 2018 17:24:00 -0300
>Subject: [PATCH] AutoEscaping - Do not escape using .raw
>
>Same as before, vars will not be escaped
>
>for x in 1 2 3 4 5; do time perl benchmark_AutoEscaping.pl; done
>perl benchmark_AutoEscaping.pl  7.43s user 3.92s system 99% cpu 11.400 total
>perl benchmark_AutoEscaping.pl  6.56s user 3.75s system 99% cpu 10.377 total
>perl benchmark_AutoEscaping.pl  6.11s user 4.08s system 99% cpu 10.233 total
>perl benchmark_AutoEscaping.pl  7.02s user 3.93s system 99% cpu 10.984 total
>perl benchmark_AutoEscaping.pl  6.91s user 3.70s system 99% cpu 10.664 total
>
>https://bugs.koha-community.org/show_bug.cgi?id=20975
>---
> benchmark_AutoEscaping.pl | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/benchmark_AutoEscaping.pl b/benchmark_AutoEscaping.pl
>index 674162d398..d627464777 100644
>--- a/benchmark_AutoEscaping.pl
>+++ b/benchmark_AutoEscaping.pl
>@@ -5,9 +5,7 @@ my $tt = Template->new(
>     {
>         ABSOLUTE    => 1,
>         PLUGIN_BASE => 'Koha::Template::Plugin',
>-        STASH       => Template::Stash::AutoEscaping->new(
>-            { ignore_escape => [qw(l)] }
>-        ),
>+        STASH       => Template::Stash::AutoEscaping->new,
>     }
> );
> 
>@@ -34,7 +32,7 @@ __DATA__
> [% pouet %]
> <div style="display:none;">
> [% FOR l IN loop %]
>-    [% l.foo %] [% l.bar %]
>+    [% l.foo.raw %] [% l.bar.raw %]
>     <br/>
> [% END %]
> </div>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20975: 76230 | 76231 | 76232 | 76233 | 76234 | 76235