Attachment 76250 Details for Bug 13655 – Bug 13655: Allow creation of organisations without entering userid

[patch] Bug 13655: Allow creation of organisations without entering userid

Bug-13655-Allow-creation-of-organisations-without-.patch (text/plain), 1.48 KB, created by Katrin Fischer on 2018-06-22 06:17:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2018-06-22 06:17:58 UTC

Size: 1.48 KB

patch

obsolete

>From bfec8663212b394cc864c37714892657347a0a8b Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 12 Apr 2018 13:40:59 -0300
>Subject: [PATCH] Bug 13655: Allow creation of organisations without entering
> userid
>
>See comment 1 of the bug report for defails of the issue.
>
>Test plan:
>Good luck (you will need to test all combinations (category type eq and
>ne 'I'), then quick edition and partial edit)
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> members/memberentry.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/members/memberentry.pl b/members/memberentry.pl
>index 0a5e81b..6ed356c 100755
>--- a/members/memberentry.pl
>+++ b/members/memberentry.pl
>@@ -277,7 +277,7 @@ $newdata{'lang'}    = $input->param('lang')    if defined($input->param('lang'))
> # builds default userid
> # userid input text may be empty or missing because of syspref BorrowerUnwantedField
> if ( ( defined $newdata{'userid'} && $newdata{'userid'} eq '' ) || $check_BorrowerUnwantedField =~ /userid/ && !defined $data{'userid'} ) {
>-    if ( ( defined $newdata{'firstname'} ) && ( defined $newdata{'surname'} ) ) {
>+    if ( ( defined $newdata{'firstname'} || $category_type eq 'I' ) && ( defined $newdata{'surname'} ) ) {
>         # Full page edit, firstname and surname input zones are present
>         $patron->firstname($newdata{firstname});
>         $patron->surname($newdata{surname});
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 13655: 74114 | 74192 | 76219 | 76239 | 76250 | 76251 | 76253 | 76254