Bugzilla – Attachment 76251 Details for
Bug 13655
Can't save organisation type patron without entering userid/password
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13655: Same fix for partial edit
Bug-13655-Same-fix-for-partial-edit.patch (text/plain), 1.42 KB, created by
Katrin Fischer
on 2018-06-22 06:18:02 UTC
(
hide
)
Description:
Bug 13655: Same fix for partial edit
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-06-22 06:18:02 UTC
Size:
1.42 KB
patch
obsolete
>From 130df166df7132451c231ae00cf7d67bae94d511 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 21 Jun 2018 12:28:18 -0300 >Subject: [PATCH] Bug 13655: Same fix for partial edit > >Test plan: >- Create an organisation with surname='xxx' >userid will be autogenerated with 'xxx'' >- Edit the surname with 'yyy' >userid will be unchanged, 'xxx' >- Parial edit and blank userid >userid will be autogenerated with 'yyy' > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > members/memberentry.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index 6ed356c..5dc318c 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -283,7 +283,7 @@ if ( ( defined $newdata{'userid'} && $newdata{'userid'} eq '' ) || $check_Borrow > $patron->surname($newdata{surname}); > $newdata{'userid'} = $patron->generate_userid; > } >- elsif ( ( defined $data{'firstname'} ) && ( defined $data{'surname'} ) ) { >+ elsif ( ( defined $data{'firstname'} || $category_type eq 'I' ) && ( defined $data{'surname'} ) ) { > # Partial page edit (access through "Details"/"Library details" tab), firstname and surname input zones are not used > # Still, if the userid field is erased, we can create a new userid with available firstname and surname > # FIXME clean thiscode newdata vs data is very confusing >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13655
:
74114
|
74192
|
76219
|
76239
|
76250
|
76251
|
76253
|
76254