Bugzilla – Attachment 76265 Details for
Bug 20271
Merge deleted biblio, biblioitems, biblio_metadata, and items tables
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20271: atomicupdate - support mysql < 5.7 and address foreign key issues
Bug-20271-atomicupdate---support-mysql--57-and-add.patch (text/plain), 3.08 KB, created by
Josef Moravec
on 2018-06-22 10:07:47 UTC
(
hide
)
Description:
Bug 20271: atomicupdate - support mysql < 5.7 and address foreign key issues
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2018-06-22 10:07:47 UTC
Size:
3.08 KB
patch
obsolete
>From ae9a80d9e3d122ca5e966f410c34ea9a10cd805a Mon Sep 17 00:00:00 2001 >From: Benjamin Rokseth <benjamin.rokseth@deichman.no> >Date: Mon, 16 Apr 2018 11:06:19 +0200 >Subject: [PATCH] Bug 20271: atomicupdate - support mysql < 5.7 and address > foreign key issues > >Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > ..._deleteitems_tables_with_their_alive_cousins.perl | 20 +++++++++++++++++--- > 1 file changed, 17 insertions(+), 3 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_20271_-_merge_deletedbiblio_and_deleteitems_tables_with_their_alive_cousins.perl b/installer/data/mysql/atomicupdate/bug_20271_-_merge_deletedbiblio_and_deleteitems_tables_with_their_alive_cousins.perl >index 47a47cc..4098ff6 100644 >--- a/installer/data/mysql/atomicupdate/bug_20271_-_merge_deletedbiblio_and_deleteitems_tables_with_their_alive_cousins.perl >+++ b/installer/data/mysql/atomicupdate/bug_20271_-_merge_deletedbiblio_and_deleteitems_tables_with_their_alive_cousins.perl >@@ -9,9 +9,23 @@ if( CheckVersion( $DBversion ) ) { > # Bug 17196 introduced a mismatch in foreign keys of deletedbiblio_metadata, so any key must be dropped > DropAllForeignKeys('deletedbiblio_metadata'); > $dbh->do( "INSERT IGNORE INTO biblio SELECT *, timestamp AS deleted_at FROM deletedbiblio" ) or warn $DBI::errstr; >- $dbh->do( "INSERT IGNORE INTO biblioitems SELECT *, timestamp AS deleted_at FROM deletedbiblioitems" ) or warn $DBI::errstr; >- $dbh->do( "INSERT IGNORE INTO biblio_metadata SELECT *, timestamp AS deleted_at FROM deletedbiblio_metadata" ) or warn $DBI::errstr; >- $dbh->do( "INSERT IGNORE INTO items SELECT *, timestamp AS deleted_at FROM deleteditems" ) or warn $DBI::errstr; >+ # We also need to make sure foreign keys references are in place, as Mysql < 5.7 aborts on foreign key errors >+ $dbh->do( "INSERT IGNORE INTO biblioitems ( >+ SELECT *, timestamp AS deleted_at FROM deletedbiblioitems >+ WHERE biblionumber IN (SELECT biblionumber FROM biblio) >+ )" ) or warn $DBI::errstr; >+ # biblio_metadata needs special handling since there is an extra autoincrement id that cannot be moved >+ $dbh->do( "INSERT IGNORE INTO biblio_metadata (biblionumber, format, marcflavour, metadata, timestamp, deleted_at) ( >+ SELECT biblionumber, format, marcflavour, metadata, timestamp, timestamp AS deleted_at FROM deletedbiblio_metadata >+ WHERE biblionumber IN (SELECT biblionumber FROM biblio) >+ )" ) or warn $DBI::errstr; >+ $dbh->do( "INSERT IGNORE INTO items ( >+ SELECT *, timestamp AS deleted_at FROM deleteditems >+ WHERE biblioitemnumber IN (SELECT biblioitemnumber FROM biblioitems) >+ AND homebranch IN (SELECT homebranch FROM branches) >+ AND holdingbranch IN (SELECT holdingbranch FROM branches) >+ AND biblionumber IN (SELECT biblionumber FROM biblio) >+ )" ) or warn $DBI::errstr; > > # Check if any rows could not be moved, if so, rename table with underscore for checking, otherwise drop them > { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20271
:
72300
|
72799
|
72800
|
73091
|
73092
|
73093
|
73535
|
73536
|
73537
|
73538
|
73539
|
73540
|
73597
|
73759
|
73760
|
73761
|
73762
|
73763
|
73764
|
73765
|
74127
|
74128
|
74129
|
74130
|
74131
|
74132
|
74133
|
74134
|
74135
|
74136
|
74137
|
74138
|
74139
|
74140
|
74141
|
74142
|
74182
|
74183
|
74184
|
74185
|
74186
|
74187
|
74188
|
74189
|
74190
|
74223
|
74407
|
74408
|
74409
|
74410
|
74411
|
74412
|
74413
|
74414
|
74415
|
74416
|
75265
|
75347
|
75894
|
75897
|
75898
|
75899
|
75910
|
75977
|
75978
|
75979
|
75980
|
75981
|
75982
|
75983
|
75984
|
75985
|
75986
|
75987
|
75988
|
75989
|
75990
|
75991
|
75992
|
75993
|
76047
|
76048
|
76255
|
76256
|
76257
|
76258
|
76259
|
76260
|
76261
|
76262
|
76263
|
76264
|
76265
|
76266
|
76267
|
76268
|
76269
|
76270
|
76271
|
76272
|
76273
|
76274
|
76275
|
76276
|
76277
|
76493
|
76494
|
76495
|
76496
|
76497
|
76498
|
76499
|
76500
|
76501
|
76502
|
76503
|
76504
|
76505
|
76506
|
76507
|
76508
|
76509
|
76510
|
76511
|
76512
|
76513
|
76514