Attachment 76377 Details for Bug 16653 – Bug 16653: (QA follow-up) Avoid a warning and remove unused variables

[patch] Bug 16653: (QA follow-up) Avoid a warning and remove unused variables

Bug-16653-QA-follow-up-Avoid-a-warning-and-remove-.patch (text/plain), 1.56 KB, created by Julian Maurice on 2018-06-25 12:59:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2018-06-25 12:59:43 UTC

Size: 1.56 KB

patch

obsolete

>From e15801b4ec435e69236b6d3faf796dd2b6502979 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Mon, 25 Jun 2018 14:58:17 +0200
>Subject: [PATCH] Bug 16653: (QA follow-up) Avoid a warning and remove unused
> variables
>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>---
> reports/cat_issues_top.pl | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
>diff --git a/reports/cat_issues_top.pl b/reports/cat_issues_top.pl
>index c7a974bd03..604258e9c9 100755
>--- a/reports/cat_issues_top.pl
>+++ b/reports/cat_issues_top.pl
>@@ -93,7 +93,7 @@ if ($do_it) {
>             print $line->{rowtitle}.$sep;
>             foreach my $cell (@$x) {
>                 print $cell->{value}.$sep;
>-                print $cell->{count};
>+                print $cell->{count} // '';
>             }
>             print "\n";
>         }
>@@ -102,10 +102,6 @@ if ($do_it) {
> # Displaying choices
> } else {
>     my $dbh = C4::Context->dbh;
>-    my @values;
>-    my %labels;
>-    my %select;
>-    my $req;
>     
>     my $CGIextChoice = ( 'CSV' ); # FIXME translation
>     my $CGIsepChoice=GetDelimiterChoices;
>@@ -157,7 +153,6 @@ sub calculate {
>     my ($line, $column, $filters) = @_;
>     my @mainloop;
>     my @loopcol;
>-    my @loopline;
>     my @looprow;
>     my %globalline;
>     my $grantotal =0;
>@@ -357,7 +352,6 @@ sub calculate {
>     
>     my $dbcalc = $dbh->prepare($strcalc);
>     $dbcalc->execute;
>-    my $previous_col;
>     my %indice;
>     while (my  @data = $dbcalc->fetchrow) {
>         my ($row, $rank, $id, $callnum, $ccode, $loc, $col )=@data;
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 16653: 75886 | 75937 | 76376 | 76377