Bugzilla – Attachment 76511 Details for
Bug 20271
Merge deleted biblio, biblioitems, biblio_metadata, and items tables
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20271: (QA follow-up) Fix catalogue statistics in reports module
Bug-20271-QA-follow-up-Fix-catalogue-statistics-in.patch (text/plain), 3.10 KB, created by
Josef Moravec
on 2018-06-27 13:39:10 UTC
(
hide
)
Description:
Bug 20271: (QA follow-up) Fix catalogue statistics in reports module
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2018-06-27 13:39:10 UTC
Size:
3.10 KB
patch
obsolete
>From d337287ab16141bcca18adbff98526ceb7b493b1 Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Fri, 22 Jun 2018 08:29:58 +0000 >Subject: [PATCH] Bug 20271: (QA follow-up) Fix catalogue statistics in reports > module > >Test plan: >1) Have some deleted and some not deleted items >2) Use catalogue statistics in reports module and try to filter >total/deleted items >--> without this patch the deleted options returns not deleted items and >total returns deleted items >--> with this patch you should be able to filter the results to deleted, > not deleted and all items and everyone of this filter should work > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt | 6 +++++- > reports/catalogue_stats.pl | 4 ++-- > 2 files changed, 7 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt >index 0347e72..5158a1c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt >@@ -245,7 +245,7 @@ > <legend>Cell value</legend> > <ol> > <li> >- <label for="cellvalue_items">Count total items</label> >+ <label for="cellvalue_items">Count not deleted items</label> > <input type="radio" name="Cellvalue" value="items" id="cellvalue_items" checked="checked" /> > </li> > <li> >@@ -256,6 +256,10 @@ > <label for="cellvalue_deleteditems">Count deleted items</label> > <input type="radio" name="Cellvalue" value="deleteditems" id="cellvalue_deleteditems" /> > </li> >+ <li> >+ <label for="cellvalue_allitems">Count all items (deleted and not deleted)</label> >+ <input type="radio" name="Cellvalue" value="allitems" id="cellvalue_allitems" /> >+ </li> > </ol> > </fieldset> > >diff --git a/reports/catalogue_stats.pl b/reports/catalogue_stats.pl >index 54f63a8..7a4e637 100755 >--- a/reports/catalogue_stats.pl >+++ b/reports/catalogue_stats.pl >@@ -46,7 +46,7 @@ my $fullreportname = "reports/catalogue_stats.tt"; > my $do_it = $input->param('do_it'); > my $line = $input->param("Line"); > my $column = $input->param("Column"); >-my $cellvalue = $input->param("Cellvalue"); # one of 'items', 'biblios' >+my $cellvalue = $input->param("Cellvalue"); # one of 'items', 'biblios', 'deleteditems', 'allitems' > my @filters = $input->multi_param("Filter"); > my $cotedigits = $input->param("cotedigits"); > my $output = $input->param("output"); >@@ -175,7 +175,7 @@ sub calculate { > my $itemstable = 'items'; > my $deleted_where = "items.deleted_on IS NULL"; > $deleted_where = "1" if $cellvalue eq 'allitems'; >- $deleted_where = "items.deleted_on IS NOT NULL" if $cellvalue eq 'items'; >+ $deleted_where = "items.deleted_on IS NOT NULL" if $cellvalue eq 'deleteditems'; > > my $dbh = C4::Context->dbh; > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20271
:
72300
|
72799
|
72800
|
73091
|
73092
|
73093
|
73535
|
73536
|
73537
|
73538
|
73539
|
73540
|
73597
|
73759
|
73760
|
73761
|
73762
|
73763
|
73764
|
73765
|
74127
|
74128
|
74129
|
74130
|
74131
|
74132
|
74133
|
74134
|
74135
|
74136
|
74137
|
74138
|
74139
|
74140
|
74141
|
74142
|
74182
|
74183
|
74184
|
74185
|
74186
|
74187
|
74188
|
74189
|
74190
|
74223
|
74407
|
74408
|
74409
|
74410
|
74411
|
74412
|
74413
|
74414
|
74415
|
74416
|
75265
|
75347
|
75894
|
75897
|
75898
|
75899
|
75910
|
75977
|
75978
|
75979
|
75980
|
75981
|
75982
|
75983
|
75984
|
75985
|
75986
|
75987
|
75988
|
75989
|
75990
|
75991
|
75992
|
75993
|
76047
|
76048
|
76255
|
76256
|
76257
|
76258
|
76259
|
76260
|
76261
|
76262
|
76263
|
76264
|
76265
|
76266
|
76267
|
76268
|
76269
|
76270
|
76271
|
76272
|
76273
|
76274
|
76275
|
76276
|
76277
|
76493
|
76494
|
76495
|
76496
|
76497
|
76498
|
76499
|
76500
|
76501
|
76502
|
76503
|
76504
|
76505
|
76506
|
76507
|
76508
|
76509
|
76510
|
76511
|
76512
|
76513
|
76514