Bugzilla – Attachment 76521 Details for
Bug 20946
Cannot pay fines for patrons with credits
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20946: Avoid summing the list twice
Bug-20946-Avoid-summing-the-list-twice.patch (text/plain), 799 bytes, created by
Kyle M Hall (khall)
on 2018-06-27 14:43:08 UTC
(
hide
)
Description:
Bug 20946: Avoid summing the list twice
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2018-06-27 14:43:08 UTC
Size:
799 bytes
patch
obsolete
>From e60243815b8bb78b15aa0c99b6da1ff1fe68f143 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatetsolutions.com> >Date: Wed, 27 Jun 2018 10:42:56 -0400 >Subject: [PATCH] Bug 20946: Avoid summing the list twice > >--- > Koha/Account.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/Koha/Account.pm b/Koha/Account.pm >index 518e3c3014..4be50d346f 100644 >--- a/Koha/Account.pm >+++ b/Koha/Account.pm >@@ -306,7 +306,8 @@ sub outstanding_debits { > ); > > # sum returns undef it list is empty >- my $total = sum( $lines->get_column('amountoutstanding') ) ? sum( $lines->get_column('amountoutstanding') ) + 0 : 0; >+ my $sum = sum( $lines->get_column('amountoutstanding') ); >+ my $total = $sum ? $sum : 0; > > return ( $total, $lines ); > } >-- >2.15.2 (Apple Git-101.1)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20946
:
76116
|
76317
|
76318
|
76394
|
76395
|
76432
|
76433
|
76434
|
76435
|
76437
|
76519
|
76521
|
76522
|
76632