Bugzilla – Attachment 76525 Details for
Bug 20990
Add Koha::Account::outstanding_credits
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20990: Make same changes that were made to outstanding_debits
Bug-20990-Make-same-changes-that-were-made-to-outs.patch (text/plain), 2.32 KB, created by
Tomás Cohen Arazi (tcohen)
on 2018-06-27 15:23:14 UTC
(
hide
)
Description:
Bug 20990: Make same changes that were made to outstanding_debits
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2018-06-27 15:23:14 UTC
Size:
2.32 KB
patch
obsolete
>From 3c3a5c1854cabd6cb1de4d5e4605469e418dddfb Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 26 Jun 2018 14:31:40 +0000 >Subject: [PATCH] Bug 20990: Make same changes that were made to > outstanding_debits > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Account.pm | 16 +++------------- > t/db_dependent/Koha/Account.t | 6 +++++- > 2 files changed, 8 insertions(+), 14 deletions(-) > >diff --git a/Koha/Account.pm b/Koha/Account.pm >index 3ffb7f4bb6..3af18cf995 100644 >--- a/Koha/Account.pm >+++ b/Koha/Account.pm >@@ -434,19 +434,6 @@ my ( $total, $lines ) = Koha::Account->new({ patron_id => $patron_id })->outstan > sub outstanding_credits { > my ($self) = @_; > >- my $outstanding_credits = Koha::Account::Lines->search( >- { borrowernumber => $self->{patron_id}, >- amountoutstanding => { '<' => 0 } >- }, >- { select => [ { sum => 'amountoutstanding' } ], >- as => ['outstanding_credits_total'], >- } >- ); >- my $total >- = ( $outstanding_credits->count ) >- ? $outstanding_credits->next->get_column('outstanding_credits_total') + 0 >- : 0; >- > my $lines = Koha::Account::Lines->search( > { > borrowernumber => $self->{patron_id}, >@@ -454,6 +441,9 @@ sub outstanding_credits { > } > ); > >+ # sum returns undef if list is empty >+ my $total = sum0( $lines->get_column('amountoutstanding') ); >+ > return ( $total, $lines ); > } > >diff --git a/t/db_dependent/Koha/Account.t b/t/db_dependent/Koha/Account.t >index 075073b02e..6d92fa27fa 100755 >--- a/t/db_dependent/Koha/Account.t >+++ b/t/db_dependent/Koha/Account.t >@@ -84,7 +84,7 @@ subtest 'outstanding_debits() tests' => sub { > > subtest 'outstanding_credits() tests' => sub { > >- plan tests => 5; >+ plan tests => 7; > > $schema->storage->txn_begin; > >@@ -108,6 +108,10 @@ subtest 'outstanding_credits() tests' => sub { > $i++; > } > >+ ( $total, $lines ) = Koha::Account->new({ patron_id => 'InvalidBorrowernumber' })->outstanding_credits(); >+ is( $total, 0, "Total if no outstanding credits is 0" ); >+ is( $lines->count, 0, "With no outstanding credits, we get back a Lines object with 0 lines" ); >+ > $schema->storage->txn_rollback; > }; > >-- >2.18.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20990
:
76380
|
76381
|
76405
|
76406
|
76407
|
76446
|
76447
|
76448
|
76449
|
76525
|
76640
|
76739
|
76740
|
76741
|
76742
|
76743