Attachment 76539 Details for Bug 20991 – Bug 20991: Do not lost patron's category when editing a patron

[patch] Bug 20991: Do not lost patron's category when editing a patron

Bug-20991-Do-not-lost-patrons-category-when-editin.patch (text/plain), 1.60 KB, created by Josef Moravec on 2018-06-27 20:43:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2018-06-27 20:43:12 UTC

Size: 1.60 KB

patch

obsolete

>From 338e392d8e40f21c13d5c8443720f263d940832f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 26 Jun 2018 13:04:01 -0300
>Subject: [PATCH] Bug 20991: Do not lost patron's category when editing a
> patron
>
>If there is an error in the edit patron form the patron's category is
>lost.
>This seems to be a long standing bug.
>
>Test plan:
>- Edit an existing patron
>- Change the patron category to a category that triggers the error that
>the user is not in the right age range for that new category
>- Save, error is triggered
>=> Without this patch the patron category has been reset
>
>You should also test different ways to edit/add a patron (quick add,
>step 1)
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> members/memberentry.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/members/memberentry.pl b/members/memberentry.pl
>index 5dc318c..f10002a 100755
>--- a/members/memberentry.pl
>+++ b/members/memberentry.pl
>@@ -614,7 +614,7 @@ foreach my $category_type (qw(C A S P I X)) {
>           { 'categorycode' => $patron_category->categorycode,
>             'categoryname' => $patron_category->description,
>             'categorycodeselected' =>
>-              ( ( defined( $borrower_data->{'categorycode'} ) && $patron_category->categorycode eq $borrower_data->{'categorycode'} ) || ( defined($categorycode) && $patron_category->categorycode eq $categorycode ) ),
>+              ( defined($categorycode) && $patron_category->categorycode eq $categorycode ),
>           };
>     }
>     my %typehash;
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20991: 76457 | 76473 | 76539