Attachment 76543 Details for Bug 20559 – Bug 20559: Occurrences of loading-small.gif still exist

[patch] Bug 20559: Occurrences of loading-small.gif still exist

Bug-20559-Occurrences-of-loading-smallgif-still-ex.patch (text/plain), 2.84 KB, created by Jonathan Druart on 2018-06-28 13:21:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-06-28 13:21:01 UTC

Size: 2.84 KB

patch

obsolete

>From 2d64bab4d3e4a080ababb91ec462fb26a431cabb Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 25 Jun 2018 14:54:08 +0000
>Subject: [PATCH] Bug 20559: Occurrences of loading-small.gif still exist
>
>This patch removes some leftover references to a file which no longer
>exists. In the OPAC, loading-small.gif was included in CSS which was
>never used. In the staff client, loading-small.gif should have been
>corrected to spinner-small.gif.
>
>To test, apply the patch and go to Tools -> Batch record modification.
>
> - Submit a batch of records to modify
> - In the table of titles which will be modified, click the 'Show MARC'
>   button.
>   - The modal preview window should show "Loading" and an animated
>     spinner before the MARC record is loaded.
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../en/modules/tools/batch_record_modification.tt  |  2 +-
> koha-tmpl/opac-tmpl/bootstrap/less/opac.less       | 24 ----------------------
> 2 files changed, 1 insertion(+), 25 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>index a1d5d7535c..bb0962d517 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>@@ -124,7 +124,7 @@
>                         <h3 id="marcPreviewLabel">MARC preview</h3>
>                     </div>
>                     <div class="modal-body">
>-                        <div id="loading"> <img src="[% interface %]/[% theme %]/img/loading-small.gif" alt="" /> Loading </div>
>+                        <div id="loading"> <img src="[% interface %]/[% theme %]/img/spinner-small.gif" alt="" /> Loading </div>
>                     </div>
>                     <div class="modal-footer">
>                         <button class="btn btn-default" data-dismiss="modal" aria-hidden="true">Close</button>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/less/opac.less b/koha-tmpl/opac-tmpl/bootstrap/less/opac.less
>index 88b350a638..a078bb5109 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/less/opac.less
>+++ b/koha-tmpl/opac-tmpl/bootstrap/less/opac.less
>@@ -657,30 +657,6 @@ ul.ui-tabs-nav li {
> 
> /* end jQueryUI core */
> 
>-/* jQueryUI autocomplete */
>-
>-.ui-autocomplete {
>-    position: absolute;
>-    cursor: default;
>-    .shadowed;
>-}
>-.ui-autocomplete.ui-widget-content .ui-state-hover {
>-    border: 1px solid #AAA;
>-    background: #E6F0F2 none;
>-    font-weight: normal;
>-    color: #212121;
>-}
>-.ui-autocomplete-loading {
>-    background: #FFF url("../../img/loading-small.gif") right center no-repeat;
>-}
>-.ui-menu li {
>-    list-style:none;
>-}
>-
>-/* end jQueryUI autocomplete */
>-
>-
>-
> th {
>     background-color: #ECEDE6;
> }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20559: 76385 | 76386 | 76528 | 76529 | 76543 | 76544