Attachment 76558 Details for Bug 20945 – Bug 20945: Escape SQL parameters when constructing download links

[patch] Bug 20945: Escape SQL parameters when constructing download links

Bug-20945-Escape-SQL-parameters-when-constructing-.patch (text/plain), 1.37 KB, created by Martin Renvoize (ashimema) on 2018-06-29 09:42:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2018-06-29 09:42:08 UTC

Size: 1.37 KB

patch

obsolete

>From 0c33aee0c0c4e078ee24e84d6fe605ad8df7fd61 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 14 Jun 2018 14:20:44 +0000
>Subject: [PATCH] Bug 20945: Escape SQL parameters when constructing download
> links
>
>TO test:
>1 - Create a report that takes a parameter
>2 - Enter a parameter containing '%'
>3 - Attempt to download report, note link is misconstructed
>4 - Apply patch
>5 - Reload
>6 - Note URL is now correct
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>index 99ce946084..b773c9bfcc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>@@ -49,7 +49,7 @@
> 
>         [% IF ( execute ) %]
>             [% BLOCK params %]
>-                [%- FOREACH param IN sql_params %]&amp;sql_params=[% param %][% END %]
>+                [%- FOREACH param IN sql_params %]&amp;sql_params=[% param | uri %][% END %]
>                     [%- FOREACH param_name IN param_names %]&amp;param_name=[% param_name %][% END %]
>             [%- END %]
> 
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 20945: 76056 | 76423 | 76558 | 76587