Attachment 76563 Details for Bug 21020 – Bug 21020: Fix return branch on transfer - SIP

[patch] Bug 21020: Fix return branch on transfer - SIP

Bug-21020-Fix-return-branch-on-transfer---SIP.patch (text/plain), 1.65 KB, created by Jonathan Druart on 2018-06-29 13:08:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-06-29 13:08:40 UTC

Size: 1.65 KB

patch

obsolete

>From b4fee6c983adc717deb957969b7faa59b79f38d3 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 29 Jun 2018 10:06:31 -0300
>Subject: [PATCH] Bug 21020: Fix return branch on transfer - SIP
>
>Caused by
>  commit 546379cc92b733cb29a0b70247a72c770afdad26
>  Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls
>
>Since this commit AddReturn return a Koha::Issue object, not a hashref
>with item's info.
>
>Test plan:
>?
>---
> C4/SIP/ILS/Transaction/Checkin.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm
>index 2ad3df5394..4d5a1e22f6 100644
>--- a/C4/SIP/ILS/Transaction/Checkin.pm
>+++ b/C4/SIP/ILS/Transaction/Checkin.pm
>@@ -65,7 +65,7 @@ sub do_checkin {
>                    . substr( $return_date, 16, 2 );
> 
>     $debug and warn "do_checkin() calling AddReturn($barcode, $branch)";
>-    my ($return, $messages, $iteminformation, $borrower) = AddReturn($barcode, $branch, undef, undef, $return_date);
>+    my ($return, $messages, $issue, $borrower) = AddReturn($barcode, $branch, undef, undef, $return_date);
>     $self->alert(!$return);
>     # ignoring messages: NotIssued, WasLost, WasTransfered
> 
>@@ -94,7 +94,7 @@ sub do_checkin {
>         $self->alert_type('04');            # send to other branch
>     }
>     if ($messages->{WasTransfered}) { # set into transit so tell unit
>-        $self->{item}->destination_loc($iteminformation->{homebranch});
>+        $self->{item}->destination_loc($issue->issue->homebranch);
>         $self->alert_type('04');            # send to other branch
>     }
>     if ($messages->{ResFound}) {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21020: 76563 | 76570 | 76574 | 76716