Bugzilla – Attachment 76592 Details for
Bug 20806
Item type in holds history table should be written as description, not code
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20806: Do not rely on column position
Bug-20806-Do-not-rely-on-column-position.patch (text/plain), 1.39 KB, created by
Jonathan Druart
on 2018-06-29 20:31:59 UTC
(
hide
)
Description:
Bug 20806: Do not rely on column position
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-06-29 20:31:59 UTC
Size:
1.39 KB
patch
obsolete
>From 85dd556b60dcdf9ca1e85753a05a40c7639ad411 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 29 Jun 2018 17:30:39 -0300 >Subject: [PATCH] Bug 20806: Do not rely on column position > >It is not the first time we have this splice call, it seems safer to >rely on the column's name instead of the column's position > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt >index ff19d79c36..8ba606f5dc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt >@@ -125,7 +125,7 @@ > var columns_settings = [% ColumnsSettings.GetColumns('members', 'holdshistory', 'holdshistory-table', 'json') %]; > [% UNLESS show_itemtype_column %] > //Remove item type column settings >- columns_settings.splice(8,1); >+ columns_settings = columns_settings.filter(function(c){return c['columnname'] != 'itemtype';}); > [% END %] > var table = KohaTable("table_holdshistory", { > "sPaginationType": "four_button", >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20806
:
75625
|
76370
|
76585
|
76591
| 76592 |
76593