Bugzilla – Attachment 76605 Details for
Bug 20999
Remove invalid 'style="block"' from OPAC templates
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20999: Remove invalid 'style="block"' from OPAC templates
Bug-20999-Remove-invalid-styleblock-from-OPAC-temp.patch (text/plain), 6.99 KB, created by
Katrin Fischer
on 2018-07-01 19:01:29 UTC
(
hide
)
Description:
Bug 20999: Remove invalid 'style="block"' from OPAC templates
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-07-01 19:01:29 UTC
Size:
6.99 KB
patch
obsolete
>From 5186cdc3da2e91d5290652b2a7e44e5994940ed3 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 26 Jun 2018 15:17:21 +0000 >Subject: [PATCH] Bug 20999: Remove invalid 'style="block"' from OPAC templates > >This patch removes an invalid attribute from OPAC template markup. There >should be no visible change to the OPAC. > >To test, apply the patch and confirm that the following pages still look >correct when using various cover image sources: Coce, Amazon, Google: > > - Bibliographic detail page (opac-detail.pl) > - The shelf browser > - Catalog search results > - Recent comments > >Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 6 +++--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt | 2 +- > 4 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >index 161f279..2beeb73 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >@@ -48,7 +48,7 @@ > > [% IF ( GoogleJackets ) %] > [% IF ( item.browser_normalized_isbn ) %] >- <div style="block" title="[% item.biblionumber |url %]" class="[% item.browser_normalized_isbn %]" id="gbs-thumbnail-preview[% loop.count %]"></div> >+ <div title="[% item.biblionumber |url %]" class="[% item.browser_normalized_isbn %]" id="gbs-thumbnail-preview[% loop.count %]"></div> > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 7567a7c..106b647 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -88,7 +88,7 @@ > [% END %] > [% IF ( Koha.Preference('Coce') && Koha.Preference('CoceProviders') ) %] > [% coce_id = normalized_ean || normalized_isbn %] >- <div style="block" title="[% biblio.biblionumber %]" class="[% coce_id %]" id="coce-thumbnail-preview"></div> >+ <div title="[% biblio.biblionumber %]" class="[% coce_id %]" id="coce-thumbnail-preview"></div> > [% END %] > [% IF OpenLibraryCovers %] > <div title="[% biblio.biblionumber %]" class="[% normalized_isbn %]" id="openlibrary-thumbnail-preview"></div> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index b0bf5a6..a3a380f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -250,7 +250,7 @@ > > [% IF ( GoogleJackets ) %] > [% IF ( SEARCH_RESULT.normalized_isbn ) %] >- <span style="block" title="[% SEARCH_RESULT.biblionumber |url %]" class="[% SEARCH_RESULT.normalized_isbn %]" id="gbs-thumbnail[% loop.count %]"></span> >+ <span title="[% SEARCH_RESULT.biblionumber |url %]" class="[% SEARCH_RESULT.normalized_isbn %]" id="gbs-thumbnail[% loop.count %]"></span> > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >@@ -259,7 +259,7 @@ > [% IF ( Koha.Preference('Coce') && Koha.Preference('CoceProviders') ) %] > [% coce_id = SEARCH_RESULT.normalized_ean || SEARCH_RESULT.normalized_isbn %] > [% IF ( coce_id ) %] >- <span style="block" title="[% SEARCH_RESULT.biblionumber |url %]" class="[% coce_id %]" id="coce-thumbnail[% loop.count %]"></span> >+ <span title="[% SEARCH_RESULT.biblionumber |url %]" class="[% coce_id %]" id="coce-thumbnail[% loop.count %]"></span> > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >@@ -267,7 +267,7 @@ > > [% IF OpenLibraryCovers %] > [% IF SEARCH_RESULT.normalized_isbn %] >- <span style="block" title="[% SEARCH_RESULT.biblionumber %]" class="[% SEARCH_RESULT.normalized_isbn %]" id="openlibrary-thumbnail[% loop.count %]"></span> >+ <span title="[% SEARCH_RESULT.biblionumber %]" class="[% SEARCH_RESULT.normalized_isbn %]" id="openlibrary-thumbnail[% loop.count %]"></span> > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt >index 1b40741..4112c71 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt >@@ -135,7 +135,7 @@ > > [% IF ( GoogleJackets ) %] > [% IF ( review.normalized_isbn ) %] >- <div style="block" title="[% review.biblionumber |url %]" class="[% review.normalized_isbn %]" id="gbs-thumbnail[% loop.count %]"></div> >+ <div title="[% review.biblionumber |url %]" class="[% review.normalized_isbn %]" id="gbs-thumbnail[% loop.count %]"></div> > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20999
:
76458
|
76598
| 76605