Attachment 76608 Details for Bug 7960 – Bug 7960: Add class to item type descriptions so they can be hidden with CSS

[patch] Bug 7960: Add class to item type descriptions so they can be hidden with CSS

Bug-7960-Add-class-to-item-type-descriptions-so-th.patch (text/plain), 18.28 KB, created by Aleisha Amohia on 2018-07-01 23:56:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aleisha Amohia

Created: 2018-07-01 23:56:32 UTC

Size: 18.28 KB

patch

obsolete

>From 88a70ef5452092419b71d1eb1945fec69d09a232 Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Sun, 1 Jul 2018 23:33:07 +0000
>Subject: [PATCH] Bug 7960: Add class to item type descriptions so they can be
> hidden with CSS
>
>This patch adds the class "itypetext" around item type descriptions so
>they can easily be hidden with CSS.
>
>To test:
>1. Navigate to the pages listed below to confirm that the text
>descriptions do show.
>2. Add
>.itypetext { display:none; }
>to IntranetUserCSS and OPACUserCSS system preferences and save.
>3. Go back to the pages listed below and confirm that the text
>descriptions DO NOT show.
>
>= STAFF CLIENT =
> - catalogue/advsearch.tt
> - catalogue/detail.tt
> - catalogue/results.tt
> - reserve/request.tt
> - virtualshelves/shelves.tt
>= OPAC =
> - opac-advsearch.tt
> - opac-detail.tt
> - opac-readingrecord.tt
> - opac-reserve.tt
> - opac-results-grouped.tt
> - opac-shelves.tt
> - opac-user.tt
>
>Sponsored-by: Catalyst IT
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 4 ++--
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 8 ++++----
> koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 ++--
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt | 4 ++--
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 4 ++--
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 2 +-
> 12 files changed, 19 insertions(+), 19 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
>index 5be1aa54..c439829 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
>@@ -119,7 +119,7 @@
> <tr>
> [% FOREACH itemtypeloo IN advsearchloo.code_loop %]
> <td><input type="checkbox" id="[% itemtypeloo.ccl FILTER remove(',') %]-[% itemtypeloo.number %]" name="limit" value="mc-[% itemtypeloo.ccl %]:[% itemtypeloo.code %]"/><label for="[% itemtypeloo.ccl FILTER remove(',') %]-[% itemtypeloo.number %]">[% UNLESS ( noItemTypeImages ) %][% IF ( itemtypeloo.imageurl ) %]<img src="[% itemtypeloo.imageurl %]" alt="[% itemtypeloo.description %]" />[% END %]&nbsp;[% END %]
>- [% itemtypeloo.description %]</label></td>
>+ [% itemtypeloo.description %]</label></td>
> [% IF ( loop.last ) %]</tr>[% ELSE %][% UNLESS ( loop.count % 5 ) %]</tr><tr>[% END %][% END %]
> [% END %]
> </table>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index ec6695c..799ecfb 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -365,7 +365,7 @@
> [% IF !noItemTypeImages && item.imageurl %]
> <img src="[% item.imageurl %]" alt="[% item.translated_description %]" title="[% item.translated_description %]" />
> [% END %]
>- [% item.translated_description %]
>+ [% item.translated_description %]
> </td>
> [% END %]
> <td class="location">[% UNLESS ( singlebranchmode ) %][% Branches.GetName( item.branchcode ) %] [% END %]</td>
>@@ -755,7 +755,7 @@
> <div id="editions"><h4>Editions</h4>
> <table>
> [% FOREACH XISBN IN XISBNS %]<tr>[% IF ( AmazonCoverImages ) %]<td><a href="http://www.amazon.com/gp/reader/[% XISBN.normalized_isbn %][% AmazonAssocTag %]#reader-link"><img src="https://images-na.ssl-images-amazon.com/images/P/[% XISBN.normalized_isbn %].01._AA75_PU_PU-5_.jpg" /></a></td>[% END %]
>-[% UNLESS ( item_level_itypes ) %]<td>[% IF ( noItemTypeImages ) %][% XISBN.description %][% ELSE %]<img src="[% XISBN.imageurl %]" alt="[% XISBN.description %]" title="[% XISBN.description %]">[% END %]</td>[% END %]
>+[% UNLESS ( item_level_itypes ) %]<td>[% IF ( noItemTypeImages ) %][% XISBN.description %][% ELSE %]<img src="[% XISBN.imageurl %]" alt="[% XISBN.description %]" title="[% XISBN.description %]">[% END %]</td>[% END %]
> <td><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% XISBN.biblionumber %]">[% XISBN.title |html %]</a> by [% XISBN.author | html %] &copy;[% XISBN.copyrightdate %]
> [% IF ( XISBN.publishercode ) %]
> [% XISBN.publishercode %] [% IF ( XISBN.place ) %]([% XISBN.place %])[% END %] [% IF ( XISBN.publicationyear ) %], [% XISBN.publicationyear %][% END %] [% IF ( XISBN.editionstatement ) %][% XISBN.editionstatement %][% END %] [% IF ( XISBN.editionresponsibility ) %][% XISBN.editionresponsibility %][% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>index bb294cd..1ed5607 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>@@ -390,7 +390,7 @@
> [% IF !noItemTypeImages && SEARCH_RESULT.imageurl %]
> <img src="[% SEARCH_RESULT.imageurl %]" alt="[% SEARCH_RESULT.description %]" />
> [% END %]
>- [% SEARCH_RESULT.description %]
>+ [% SEARCH_RESULT.description %]
> </div>
> [% END %]
> 
>@@ -502,7 +502,7 @@
> [% IF ( available_items_loo.itemcallnumber ) %][<a href="/cgi-bin/koha/catalogue/search.pl?idx=callnum&amp;q=%22[% available_items_loo.itemcallnumber |uri %]%22">[% available_items_loo.itemcallnumber %]</a>][% END %]
> ([% available_items_loo.count %])
> [% IF item_level_itypes && available_items_loo.description %]
>- [% available_items_loo.description %]
>+ [% available_items_loo.description %]
> [% END %]
> </li>
> [% END %]
>@@ -524,7 +524,7 @@
> [% IF ( onloan_items_loo.itemcallnumber ) %][<a href="/cgi-bin/koha/catalogue/search.pl?idx=callnum&amp;q=%22[% onloan_items_loo.itemcallnumber |uri %]%22">[% onloan_items_loo.itemcallnumber %]</a>][% END %]
> ([% onloan_items_loo.count %][% IF ( onloan_items_loo.longoverdue ) %], [% onloan_items_loo.longoverdue %] long overdue[% END %]) date due: [% onloan_items_loo.due_date | $KohaDates %]
> [% IF item_level_itypes && onloan_items_loo.description %]
>- [% onloan_items_loo.description %]
>+ [% onloan_items_loo.description %]
> [% END %]
> </li>
> [% END %]
>@@ -552,7 +552,7 @@
> [% IF ( other_items_loo.notforloan ) %][% other_items_loo.notforloan %][% END %]
> ([% other_items_loo.count %])
> [% IF item_level_itypes && other_items_loo.description %]
>- [% other_items_loo.description %]
>+ [% other_items_loo.description %]
> [% END %]
> </li>
> [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index 91e9e5b..abacb88 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -554,7 +554,7 @@ function checkMultiHold() {
> [% UNLESS ( noItemTypeImages ) %]
> [% IF ( itemloo.imageurl ) %]<img src="[% itemloo.imageurl %]" alt="" /> [% END %]
> [% END %]
>- [% itemloo.itypename %]
>+ [% itemloo.itypename %]
> </td>
> [% END %]
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>index 35a70ff..cd45204 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>@@ -200,7 +200,7 @@
> </td>
> [% END %]
> 			[% UNLESS ( item_level_itypes ) %]<td>
>- [% UNLESS ( noItemTypeImages || !itemsloo.imageurl ) %]<img src="[% itemsloo.imageurl %]" alt="[% itemsloo.description %]" title="[% itemsloo.description %]" />[% END %][% itemsloo.description %]
>+ [% UNLESS ( noItemTypeImages || !itemsloo.imageurl ) %]<img src="[% itemsloo.imageurl %]" alt="[% itemsloo.description %]" title="[% itemsloo.description %]" />[% END %][% itemsloo.description %]
> 			</td>[% END %]
> 			<td>
> [% IF ( itemsloo.XSLTBloc ) %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
>index 620d83b..b2472c4 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
>@@ -149,7 +149,7 @@
> [% END %]
> &nbsp;
> [% END %]
>- [% itemtypeloo.description %]
>+ [% itemtypeloo.description %]
> </label>
> </div>
> [% IF ( loop.last ) %]</div>[% ELSE %][% UNLESS ( loop.count % 4 ) %]</div><div class="row-fluid">[% END %][% END %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index 7567a7c..0009eb4 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -329,7 +329,7 @@
> [% IF ( imgeurl ) %]
> <img src="[% imageurl %]" alt="" />
> [% END %]
>- Item type: 
>+ Item type: 
> [% IF ( description ) %]
> [% description %]
> [% ELSE %]
>@@ -1231,7 +1231,7 @@
> <img src="[% ITEM_RESULT.imageurl %]" title="[% ITEM_RESULT.description %]" alt="[% ITEM_RESULT.description %]" />
> [% END %]
> [% END %]
>- [% ITEM_RESULT.description %]
>+ [% ITEM_RESULT.description %]
> </td>
> [% END %]
> [% IF ( OpacLocationBranchToDisplay == 'holding' || OpacLocationBranchToDisplay == 'both' ) %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
>index a51c53e..1768bee 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
>@@ -142,8 +142,8 @@
> <img src="[% issue.imageurl %]" alt="" />
> [% END %]
> [% END %]
>- Item type:
>- [% issue.translated_description %]</td>
>+ Item type:
>+ [% issue.translated_description %]</td>
> <td>
> Call number:
> [% issue.itemcallnumber %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>index c5f5c84..c47b792 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>@@ -193,7 +193,7 @@
> <li class="itype">
> Item type: 
> [% IF ( bibitemloo.imageurl ) %]<img src="[% bibitemloo.imageurl %]" alt="" />[% END %]
>- [% bibitemloo.translated_description %]
>+ [% bibitemloo.translated_description %]
> </li>
> [% END %]
> 
>@@ -357,7 +357,7 @@
> <img src="[% itemLoo.imageurl %]" alt="" />
> [% END %]
> [% END %]
>- [% itemLoo.translated_description %]
>+ [% itemLoo.translated_description %]
> </td>
> [% END %]
> 
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt
>index b0ba7d5..508769b 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt
>@@ -166,7 +166,7 @@ href="/cgi-bin/koha/opac-rss.pl?[% query_cgi %][% limit_cgi |html %]" />
> <img src="[% GROUP_RESULT.imageurl %]" title="[% GROUP_RESULT.description %]" />
> [% END %]
> [% END %]
>- [% GROUP_RESULT.description %]
>+ [% GROUP_RESULT.description %]
> [% END %]
> </td>
> <td>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>index c122ae2..a800d34 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>@@ -290,7 +290,7 @@
> [% UNLESS ( noItemTypeImages ) %]
> <img src="[% itemsloo.imageurl %]" alt="[% itemsloo.description %]" title="[% itemsloo.description %]" />
> [% END %]
>- [% itemsloo.description %]
>+ [% itemsloo.description %]
> </td>
> [% END %]
> <td>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>index 85680af..caa0feb 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>@@ -252,7 +252,7 @@
> Item type:
> [% IF ( ISSUE.imageurl ) %]
> <img src="[% ISSUE.imageurl %]" title="[% ISSUE.description %]" alt="[% ISSUE.description %]" />
>- [% END %] [% ISSUE.description %]
>+ [% END %] [% ISSUE.description %]
> </td>
> [% END %]
> [% IF ( show_barcode ) %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 7960: 9189 | 62344 | 62807 | 62932 | 62933 | 76608 | 83853 | 84219 | 98778 | 137760 | 140217 | 140237 | 141284 | 141286