Attachment 76712 Details for Bug 14446 – [SIGNED-OFF] Bug 14446: Workaround to resolve uninitialized value in goto warning

[patch] [SIGNED-OFF] Bug 14446: Workaround to resolve uninitialized value in goto warning

SIGNED-OFF-Bug-14446-Workaround-to-resolve-uniniti.patch (text/plain), 1.39 KB, created by Aleisha Amohia on 2018-07-06 00:15:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aleisha Amohia

Created: 2018-07-06 00:15:45 UTC

Size: 1.39 KB

patch

obsolete

>From c82e0ae88bd347e65d6f93b69026d52f9a9215c2 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 4 Jul 2018 16:03:33 +0200
>Subject: [PATCH] [SIGNED-OFF] Bug 14446: Workaround to resolve uninitialized
> value in goto warning
>
>Forcing both GetTab calls to list context resolves the warning.
>A workaround, not a real fix.
>
>Test plan:
>Search for something in the syspref text bar.
>Without this patch, you will have a warn: Use of uninitialized value in goto
>With this patch, you won't.
>
>Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
>---
> admin/preferences.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/admin/preferences.pl b/admin/preferences.pl
>index 1e12b1e..988753a 100755
>--- a/admin/preferences.pl
>+++ b/admin/preferences.pl
>@@ -229,7 +229,8 @@ sub SearchPrefs {
>     our @terms = split( /\s+/, $searchfield );
> 
>     foreach my $tab_name ( keys %tab_files ) {
>-        my $data = GetTab( $input, $tab_name );
>+        # Force list context to remove 'uninitialized value in goto' warn coming from YAML::Syck; note that the other GetTab call is in list context too. The actual cause however is the null value for the pref OpacRenewalBranch in opac.pref
>+        my ($data) = GetTab( $input, $tab_name );
>         my $title = ( keys( %$data ) )[0];
>         my $tab = $data->{ $title };
>         $tab = { '' => $tab } if ( ref( $tab ) eq 'ARRAY' );
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 14446: 76685 | 76712 | 76756