Bugzilla – Attachment 76726 Details for
Bug 20978
Add Koha::Account::add_credit
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20978: (QA follow-up) Do not delete existing data on tests
Bug-20978-QA-follow-up-Do-not-delete-existing-data.patch (text/plain), 2.89 KB, created by
Tomás Cohen Arazi (tcohen)
on 2018-07-06 12:11:53 UTC
(
hide
)
Description:
Bug 20978: (QA follow-up) Do not delete existing data on tests
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2018-07-06 12:11:53 UTC
Size:
2.89 KB
patch
obsolete
>From 819557e65d7596c53eb518757927fa7d4b6c9b43 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 6 Jul 2018 09:11:32 -0300 >Subject: [PATCH] Bug 20978: (QA follow-up) Do not delete existing data on > tests > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/Koha/Account.t | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > >diff --git a/t/db_dependent/Koha/Account.t b/t/db_dependent/Koha/Account.t >index cfc14addf7..21f0e62191 100755 >--- a/t/db_dependent/Koha/Account.t >+++ b/t/db_dependent/Koha/Account.t >@@ -124,8 +124,8 @@ subtest 'add_credit() tests' => sub { > $schema->storage->txn_begin; > > # delete logs and statistics >- $schema->resultset('ActionLog')->search()->delete(); >- $schema->resultset('Statistic')->search()->delete(); >+ my $action_logs = $schema->resultset('ActionLog')->search()->count; >+ my $statistics = $schema->resultset('Statistic')->search()->count; > > my $patron = $builder->build_object( { class => 'Koha::Patrons' } ); > my $account = Koha::Account->new( { patron_id => $patron->borrowernumber } ); >@@ -146,8 +146,8 @@ subtest 'add_credit() tests' => sub { > ); > > is( $account->balance, -25, 'Patron has a balance of -25' ); >- is( $schema->resultset('ActionLog')->count(), 0, 'No log was added' ); >- is( $schema->resultset('Statistic')->count(), 1, 'Action added to statistics' ); >+ is( $schema->resultset('ActionLog')->count(), $action_logs + 0, 'No log was added' ); >+ is( $schema->resultset('Statistic')->count(), $statistics + 1, 'Action added to statistics' ); > is( $line_1->accounttype, $Koha::Account::account_type->{'payment'}, 'Account type is correctly set' ); > > # Enable logs >@@ -165,8 +165,8 @@ subtest 'add_credit() tests' => sub { > ); > > is( $account->balance, -62, 'Patron has a balance of -25' ); >- is( $schema->resultset('ActionLog')->count(), 1, 'Log was added' ); >- is( $schema->resultset('Statistic')->count(), 2, 'Action added to statistics' ); >+ is( $schema->resultset('ActionLog')->count(), $action_logs + 1, 'Log was added' ); >+ is( $schema->resultset('Statistic')->count(), $statistics + 2, 'Action added to statistics' ); > is( $line_2->accounttype, $Koha::Account::account_type->{'payment'} . $sip_code, 'Account type is correctly set' ); > > # offsets have the credit_id set to accountlines_id, and debit_id is undef >@@ -187,8 +187,8 @@ subtest 'add_credit() tests' => sub { > } > ); > >- is( $schema->resultset('ActionLog')->count(), 2, 'Log was added' ); >- is( $schema->resultset('Statistic')->count(), 2, 'No action added to statistics, because of credit type' ); >+ is( $schema->resultset('ActionLog')->count(), $action_logs + 2, 'Log was added' ); >+ is( $schema->resultset('Statistic')->count(), $statistics + 2, 'No action added to statistics, because of credit type' ); > > $schema->storage->txn_rollback; > }; >-- >2.18.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20978
:
76240
|
76241
|
76242
|
76243
|
76244
|
76245
|
76278
|
76279
|
76280
|
76319
|
76320
|
76321
|
76396
|
76397
|
76398
|
76439
|
76440
|
76441
|
76515
|
76633
|
76634
|
76635
|
76636
|
76726
|
76727
|
76733