Bugzilla – Attachment 76731 Details for
Bug 20980
Manual credit offsets are stored as debits
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20980: (follow-up) Offset name consistency
Bug-20980-follow-up-Offset-name-consistency.patch (text/plain), 1.07 KB, created by
Tomás Cohen Arazi (tcohen)
on 2018-07-06 12:23:02 UTC
(
hide
)
Description:
Bug 20980: (follow-up) Offset name consistency
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2018-07-06 12:23:02 UTC
Size:
1.07 KB
patch
obsolete
>From 45d17b29514ee924c5e6bf9be6a56cd5fa45601f Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Sat, 23 Jun 2018 07:41:15 -0300 >Subject: [PATCH] Bug 20980: (follow-up) Offset name consistency > >This patch makes 'credit' account types generate 'Manual Credit' offset. >The original patch used 'Payment' but I think the code wants to >distinguish between payments and manually added credits (otherwise they >would've picked the same accounttype value, and they don't. > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > Koha/Account.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Account.pm b/Koha/Account.pm >index 1541998d68..8e3ed40798 100644 >--- a/Koha/Account.pm >+++ b/Koha/Account.pm >@@ -481,7 +481,7 @@ sub non_issues_charges { > =cut > > our $offset_type = { >- 'credit' => 'Payment', >+ 'credit' => 'Manual Credit', > 'forgiven' => 'Writeoff', > 'lost_item_return' => 'Lost Item Return', > 'payment' => 'Payment', >-- >2.18.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20980
:
76299
|
76300
|
76301
|
76322
|
76323
|
76324
|
76325
|
76401
|
76402
|
76403
|
76404
|
76442
|
76443
|
76444
|
76445
|
76728
|
76729
|
76730
| 76731 |
76732
|
76734