Bugzilla – Attachment 76757 Details for
Bug 20090
Missing Script Statement for Novelist Select on Some Record Displays in OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20090: Missing script statement for Novelist Select on some record displays in OPAC
Bug-20090-Missing-script-statement-for-Novelist-Se.patch (text/plain), 3.55 KB, created by
Katrin Fischer
on 2018-07-08 14:15:17 UTC
(
hide
)
Description:
Bug 20090: Missing script statement for Novelist Select on some record displays in OPAC
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-07-08 14:15:17 UTC
Size:
3.55 KB
patch
obsolete
>From 4eb2104b3c9077db7d32d482fbb533eb7531be9f Mon Sep 17 00:00:00 2001 >From: David Kuhn <techservspec@gmail.com> >Date: Thu, 25 Jan 2018 09:27:19 -0800 >Subject: [PATCH] Bug 20090: Missing script statement for Novelist Select on > some record displays in OPAC > >This patch adds a check for UPCs and well as ISBNs to the Novelist Select conditionals in opac-detail.tt > >To test (note that you must subscribe to Novelist Select): > >1. If your library does not use the raton ratings feature, activate it for the purposes of this test. > >2. Display a record that does not have an ISBN in the 020 field, but has a upc (or other code) in the 024 field. The rating option will > >display as 5 radio buttons and a "rate it" button. > >3. Apply the patch. > >4. Display the same record again. The radio buttons will be replaced with stars. This indicates that the scripts on the page completed. > >Rather that using the patron ratings as in indicator, you can also use a web page inspector/debugger such as firebug or the built-in > >inspectors in most newer browsers to check for script errors. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >I couldn't check with Novelist Select, but read and checked changed made carefully. >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 50833cce5c..4e52e5d317 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -532,11 +532,12 @@ > </span> > [% END # / IF BakerTaylorContentURL %] > >- [% IF ( NovelistSelectProfile && normalized_isbn ) %] >+ [% IF ( NovelistSelectProfile && (normalized_isbn || normalized_upc) ) %] > [% IF ( NovelistSelectView == 'above') %] > <span class="results_summary NovelistSelect" style="display:none;"> > <span class="label">Novelist Select: </span> >- <div data-novelist-novelistselect=[% normalized_isbn %]></div> >+ <div data-novelist-novelistselect=[% IF normalized_isbn %][% normalized_isbn %][% ELSE %][% normalized_upc %][% END %]></div> >+ > </span> > [% END %] > [% END # / IF NovelistSelectProfile %] >@@ -603,7 +604,7 @@ > <li id="tab_comments"><a href="#comments">Comments[% ' ( ' _ (reviews.size || 0) _ ' )' %]</a></li> > [% END %] > >- [% IF ( NovelistSelectProfile && normalized_isbn ) %] >+ [% IF ( NovelistSelectProfile && (normalized_isbn || normalized_upc) ) %] > [% IF ( NovelistSelectView == 'tab') %] > <li id="tab_NovelistSelect" class="NovelistSelect" style="display:none;"> <a href="#NovelistSelect">Novelist Select</a></li> > [% END %] >@@ -1167,7 +1168,7 @@ > <a href="https://www.librarything.com/forlibraries/noscript.php?id=[% LibraryThingForLibrariesID %]&accessibility=1">here</a>.</noscript> > [% END %] > >- [% IF ( NovelistSelectProfile && normalized_isbn ) %] >+ [% IF ( NovelistSelectProfile && normalized_isbn || normalized_upc) ) %] > <script src="https://imageserver.ebscohost.com/novelistselect/ns2init.js"></script> > [% END %] > >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20090
:
70920
|
76757
|
76929