Bugzilla – Attachment 76800 Details for
Bug 21056
Changing the logged in library can fail sporadically
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
0001-Bug-21056-Changing-the-logged-in-library-can-fail-sp.patch (text/plain), 1.36 KB, created by
Kyle M Hall (khall)
on 2018-07-09 18:07:56 UTC
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2018-07-09 18:07:56 UTC
Size:
1.36 KB
patch
obsolete
>From 7f527f78b5c82aa73f7947c33d9ceecbf8fffb89 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 9 Jul 2018 14:05:29 -0400 >Subject: [PATCH] Bug 21056 - Changing the logged in library can fail > sporadically > >We are getting reports that sometimes changing the logged in library via selectbranchprinter.pl sometimes appears to fail. Flushing the session after updating the branch appears to fix this. > >Test Plan: >1) Change your logged in library repeatedly. Hopefully ( sort of ) it will fail to change. > You may want to try various browsers. >2) Apply this patch >3) Note the change no longer fails >--- > circ/selectbranchprinter.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/circ/selectbranchprinter.pl b/circ/selectbranchprinter.pl >index 03fa65b1ec..cff7f08013 100755 >--- a/circ/selectbranchprinter.pl >+++ b/circ/selectbranchprinter.pl >@@ -62,6 +62,7 @@ if ( $branch and my $library = Koha::Libraries->find($branch) ) { > $template->param(LoginBranchcode => $branch); # update template for new branch > $session->param('branchname', $branchname); # update sesssion in DB > $session->param('branch', $branch); # update sesssion in DB >+ $session->flush(); > push @updated, { > updated_branch => 1, > old_branch => $userenv_branch, >-- >2.15.2 (Apple Git-101.1) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21056
:
76800
|
77336
|
77337