Attachment 76839 Details for Bug 19532 – Bug 19532: POD fix, renaming methods

[patch] Bug 19532: POD fix, renaming methods

Bug-19532-POD-fix-renaming-methods.patch (text/plain), 13.40 KB, created by Alex Buckley on 2018-07-10 23:21:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Buckley

Created: 2018-07-10 23:21:55 UTC

Size: 13.40 KB

patch

obsolete

>From 41069856a837f1bed21fc498078e4d2b88d1935e Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Thu, 21 Dec 2017 03:34:22 +0000
>Subject: [PATCH] Bug 19532: POD fix, renaming methods
>
>Tomas's comments:
>- renaming 'Class methods' to 'internal methods'
>- renaming 'borrower' and 'branch' methods to 'patron' and 'library'
>
>other comments are out of date with current patches and do not need to
>be actioned
>
>when testing, confirm all data still shows as expected and nothing is
>broken
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> Koha/Recall.pm                                         | 18 +++++++++---------
> Koha/Recalls.pm                                        |  2 +-
> circ/returns.pl                                        |  2 +-
> .../intranet-tmpl/prog/en/includes/recalls-reports.inc |  4 ++--
> koha-tmpl/intranet-tmpl/prog/en/includes/recalls.inc   |  2 +-
> .../prog/en/modules/circ/recalls_overdue.tt            |  4 ++--
> .../prog/en/modules/circ/recalls_waiting.tt            | 14 +++++++-------
> .../intranet-tmpl/prog/en/modules/circ/returns.tt      |  2 +-
> .../opac-tmpl/bootstrap/en/modules/opac-recalls.tt     |  2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt  |  2 +-
> t/db_dependent/Koha/Recalls.t                          |  4 ++--
> 11 files changed, 28 insertions(+), 28 deletions(-)
>
>diff --git a/Koha/Recall.pm b/Koha/Recall.pm
>index 6e2280b..ad51e36 100644
>--- a/Koha/Recall.pm
>+++ b/Koha/Recall.pm
>@@ -29,7 +29,7 @@ Koha::Recall - Koha Recall Object class
> 
> =head1 API
> 
>-=head2 Class Methods
>+=head2 Internal Methods
> 
> =cut
> 
>@@ -70,33 +70,33 @@ sub item {
>     return $self->{_item};
> }
> 
>-=head3 borrower
>+=head3 patron
> 
> Returns the related Koha::Patron object for this recall
> 
> =cut
> 
>-sub borrower {
>+sub patron {
> 
>     my ($self) = @_;
> 
>-    $self->{_borrower} ||= Koha::Patrons->find( $self->borrowernumber() );
>+    $self->{_patron} ||= Koha::Patrons->find( $self->borrowernumber() );
> 
>-    return $self->{_borrower};
>+    return $self->{_patron};
> }
> 
>-=head3 branch
>+=head3 library
> 
> Returns the related Koha::Library object for this recall
> 
> =cut
> 
>-sub branch {
>+sub library {
>     my ($self) = @_;
> 
>-    $self->{_branch} ||= Koha::Libraries->find( $self->branchcode() );
>+    $self->{_library} ||= Koha::Libraries->find( $self->branchcode() );
> 
>-    return $self->{_branch};
>+    return $self->{_library};
> }
> 
> =head3 checkout
>diff --git a/Koha/Recalls.pm b/Koha/Recalls.pm
>index 578f7c8..804d5a5 100644
>--- a/Koha/Recalls.pm
>+++ b/Koha/Recalls.pm
>@@ -30,7 +30,7 @@ Koha::Recalls - Koha Recalls Object Set class
> 
> =head1 API
> 
>-=head2 Class Methods
>+=head2 Internal Methods
> 
> =cut
> 
>diff --git a/circ/returns.pl b/circ/returns.pl
>index 9655c7e..4947f48 100755
>--- a/circ/returns.pl
>+++ b/circ/returns.pl
>@@ -191,7 +191,7 @@ if ( $query->param('reserve_id') ) {
> 
> if ( $query->param('recall_id') ){
>     my $recall = Koha::Recalls->find(scalar $query->param('recall_id'));
>-    my $recall_borrower = $recall->borrower;
>+    my $recall_borrower = $recall->patron;
>     my $item = Koha::Items->find($recall->itemnumber);
>     my $biblio = Koha::Biblios->find($item->biblionumber);
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/recalls-reports.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/recalls-reports.inc
>index 825f98c..851e565 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/recalls-reports.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/recalls-reports.inc
>@@ -26,7 +26,7 @@
>                     </td>
>                     <td class="recall-borrower">
>                         <a class="recall-borrower" href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% recall.borrowernumber %]">
>-                            [% recall.borrower.firstname %] [% recall.borrower.surname %] ([% recall.borrowernumber %])
>+                            [% recall.patron.firstname %] [% recall.patron.surname %] ([% recall.borrowernumber %])
>                         </a>
>                     </td>
>                     <td class="recall-title">
>@@ -59,7 +59,7 @@
>                     </td>
> 
>                     <td class="recall-branch">
>-                        [% recall.branch.branchname %]
>+                        [% recall.library.branchname %]
>                     </td>
> 
>                     <td class="recall-status">
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/recalls.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/recalls.inc
>index b17288b..14d0436 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/recalls.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/recalls.inc
>@@ -45,7 +45,7 @@
>                     </td>
> 
>                     <td class="recall-branch">
>-                        [% recall.branch.branchname %]
>+                        [% recall.library.branchname %]
>                     </td>
> 
>                     <td class="recall-status">
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/recalls_overdue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/recalls_overdue.tt
>index 1138375..74de0e4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/recalls_overdue.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/recalls_overdue.tt
>@@ -57,7 +57,7 @@
>                                             </td>
>                                             <td class="recall-borrower">
>                                                 <a class="recall-borrower" href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% recall.borrowernumber %]">
>-                                                    [% recall.borrower.firstname %] [% recall.borrower.surname %] ([% recall.borrowernumber %])
>+                                                    [% recall.patron.firstname %] [% recall.patron.surname %] ([% recall.borrowernumber %])
>                                                 </a>
>                                             </td>
>                                             <td class="recall-title">
>@@ -82,7 +82,7 @@
>                                                 </a>
>                                             </td>
>                                             <td class="recall-branch">
>-                                                [% recall.branch.branchname %]
>+                                                [% recall.library.branchname %]
>                                             </td>
>                                             <td class="recall-cancel">
>                                                 <a class="btn btn-xs btn-default" id="cancel_recall" data-id="[% recall.recall_id %]"><i class="fa fa-times"></i> Cancel</a>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/recalls_waiting.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/recalls_waiting.tt
>index 6a061bf..b09acaf 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/recalls_waiting.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/recalls_waiting.tt
>@@ -75,10 +75,10 @@
>                                         </td>
>                                         <td>
>                                             <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% recall.borrowernumber %]">[% recall.borrower.firstname %] [% recall.borrower.surname %]</a>
>-                                            [% IF ( recall.borrower.phone ) %]<br />[% recall.borrower.phone %][% END %]
>-                                            [% IF ( recall.borrower.email ) %]<br /><a href="mailto:[% recall.borrower.email %]?subject=Recall waiting: [% recall.biblio.title %]">[% recall.borrower.email %]</a>[% END %]
>+                                            [% IF ( recall.patron.phone ) %]<br />[% recall.patron.phone %][% END %]
>+                                            [% IF ( recall.patron.email ) %]<br /><a href="mailto:[% recall.patron.email %]?subject=Recall waiting: [% recall.biblio.title %]">[% recall.patron.email %]</a>[% END %]
>                                         </td>
>-                                        <td>[% recall.branch.branchname %]</td>
>+                                        <td>[% recall.library.branchname %]</td>
>                                         <td>
>                                             <form action="/cgi-bin/koha/circ/recalls_waiting.pl" method="post">
>                                                 <input type="hidden" name="recall_id" value="[% recall.recall_id %]">
>@@ -122,11 +122,11 @@
>                                             <br><i>Barcode: [% recall.item.barcode %]</i>
>                                         </td>
>                                         <td>
>-                                            <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% recall.borrowernumber %]">[% recall.borrower.firstname %] [% recall.borrower.surname %]</a>
>-                                            [% IF ( recall.borrower.phone ) %]<br />[% recall.borrower.phone %][% END %]
>-                                            [% IF ( recall.borrower.email ) %]<br /><a href="mailto:[% recall.borrower.email %]?subject=Recall waiting: [% recall.biblio.title %]">[% recall.borrower.email %]</a>[% END %]
>+                                            <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% recall.borrowernumber %]">[% recall.patron.firstname %] [% recall.patron.surname %]</a>
>+                                            [% IF ( recall.patron.phone ) %]<br />[% recall.patron.phone %][% END %]
>+                                            [% IF ( recall.patron.email ) %]<br /><a href="mailto:[% recall.patron.email %]?subject=Recall waiting: [% recall.biblio.title %]">[% recall.patron.email %]</a>[% END %]
>                                         </td>
>-                                        <td>[% recall.branch.branchname %]</td>
>+                                        <td>[% recall.library.branchname %]</td>
>                                         <td>
>                                             <form action="/cgi-bin/koha/circ/recalls_waiting.pl" method="post">
>                                                 <input type="hidden" name="recall_id" value="[% recall.recall_id %]">
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index 2b683c4..046b7b4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -497,7 +497,7 @@
>                         <li class="error">Patron's address is in doubt</li>
>                     [% END %]
> 
>-                    <h4><strong>Wait for pickup at</strong> [% recall.branch.branchname %]</h4>
>+                    <h4><strong>Wait for pickup at</strong> [% recall.library.branchname %]</h4>
> 
>                     <input type="hidden" name="itemnumber" value="[% recall.itemnumber %]" />
>                     <input type="hidden" name="borrowernumber" value="[% patron.borrowernumber %]" />
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt
>index 8cf2ac8..18052a5 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt
>@@ -83,7 +83,7 @@
>                                             </td>
>                                             <td class="branch">
>                                                 <span class="tdlabel">Pick up location:</span>
>-                                                [% RECALL.branch.branchname %]
>+                                                [% RECALL.library.branchname %]
>                                             </td>
>                                             <td class="status">
>                                                 <span class="tdlabel">Status:</span>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>index 6898329..405008e 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>@@ -848,7 +848,7 @@
>                                                 </td>
>                                                 <td class="branch">
>                                                     <span class="tdlabel">Pick up location:</span>
>-                                                    [% RECALL.branch.branchname %]
>+                                                    [% RECALL.library.branchname %]
>                                                 </td>
>                                                 <td class="status">
>                                                     <span class="tdlabel">Status:</span>
>diff --git a/t/db_dependent/Koha/Recalls.t b/t/db_dependent/Koha/Recalls.t
>index 4e96e43..76ad08f 100644
>--- a/t/db_dependent/Koha/Recalls.t
>+++ b/t/db_dependent/Koha/Recalls.t
>@@ -67,11 +67,11 @@ is( $recall->has_expired, 1, 'Recall has expired' );
> 
> is( $biblio->{biblionumber}, $recall->biblio->biblionumber, 'Can access biblio from recall' );
> 
>-is( $patron->{borrowernumber}, $recall->borrower->borrowernumber, 'Can access borrower from recall' );
>+is( $patron->{borrowernumber}, $recall->patron->borrowernumber, 'Can access borrower from recall' );
> 
> is( $item->{itemnumber}, $recall->item->itemnumber, 'Can access item from recall' );
> 
>-is( $library->{branchcode}, $recall->branch->branchcode, 'Can access branch from recall' );
>+is( $library->{branchcode}, $recall->library->branchcode, 'Can access branch from recall' );
> 
> is( $checkout->{issue_id}, $recall->checkout->issue_id, 'Can access checkout from recall' );
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 19532: 68569 | 68570 | 68571 | 68572 | 68642 | 68643 | 68644 | 68645 | 68653 | 69100 | 69102 | 69147 | 69148 | 69149 | 69170 | 69172 | 69221 | 69222 | 69223 | 69322 | 69353 | 69354 | 69405 | 69409 | 69410 | 69411 | 69841 | 69872 | 69873 | 69874 | 69875 | 69876 | 69877 | 69878 | 69879 | 69880 | 69881 | 69882 | 69883 | 69884 | 69885 | 69886 | 69887 | 69888 | 69889 | 69890 | 69986 | 70093 | 71409 | 71574 | 71575 | 71576 | 71577 | 71578 | 71579 | 71580 | 71581 | 71582 | 71583 | 71584 | 71585 | 71586 | 71587 | 71588 | 71589 | 71590 | 71591 | 71592 | 72244 | 72311 | 72312 | 72313 | 72314 | 72315 | 72316 | 72317 | 72318 | 72319 | 72320 | 72321 | 72322 | 72323 | 72324 | 72325 | 72326 | 72327 | 72328 | 72329 | 72330 | 72331 | 72332 | 72333 | 72334 | 72335 | 72336 | 72337 | 72338 | 72527 | 76817 | 76818 | 76819 | 76820 | 76821 | 76822 | 76823 | 76824 | 76825 | 76826 | 76827 | 76828 | 76829 | 76830 | 76831 | 76832 | 76833 | 76834 | 76835 | 76836 | 76837 | 76838 | 76839 | 76840 | 76841 | 76842 | 76843 | 76844 | 76845 | 76846 | 76847 | 77177 | 77178 | 77179 | 78755 | 78757 | 78759 | 78761 | 78763 | 78765 | 78766 | 78768 | 78770 | 78772 | 78773 | 78774 | 78775 | 78776 | 78777 | 78778 | 78780 | 78782 | 78785 | 78787 | 78789 | 78790 | 78792 | 78794 | 78797 | 78800 | 78801 | 78802 | 78803 | 78804 | 78805 | 78806 | 78807 | 78808 | 80763 | 80764 | 80765 | 80766 | 80767 | 80768 | 80769 | 80770 | 80771 | 80772 | 80773 | 80774 | 80775 | 80776 | 80777 | 80778 | 80779 | 80780 | 80781 | 80782 | 80783 | 80784 | 80785 | 80786 | 80787 | 80788 | 80789 | 80793 | 80878 | 81204 | 81205 | 81206 | 81207 | 81208 | 81209 | 81210 | 81211 | 81212 | 81213 | 81214 | 81215 | 81216 | 81217 | 81218 | 81219 | 81220 | 81221 | 81222 | 81223 | 81224 | 81225 | 81226 | 81227 | 81228 | 81229 | 81230 | 81231 | 81232 | 81233 | 81234 | 81235 | 81236 | 81237 | 81238 | 81239 | 81240 | 81241 | 81242 | 81243 | 81244 | 81245 | 81246 | 81247 | 81547 | 81548 | 81549 | 81550 | 81551 | 81552 | 81553 | 81554 | 81555 | 81556 | 81557 | 81558 | 81559 | 81560 | 81561 | 81562 | 81563 | 81564 | 81565 | 81566 | 81567 | 81568 | 81569 | 81583 | 81584 | 81585 | 81586 | 81587 | 81588 | 81595 | 81618 | 81652 | 81653 | 81654 | 81655 | 81656 | 81657 | 81658 | 81659 | 81660 | 81661 | 81662 | 81663 | 81664 | 81665 | 81666 | 81667 | 81668 | 81669 | 81670 | 81671 | 81672 | 81673 | 81674 | 81675 | 81676 | 81677 | 81678 | 81679 | 81680 | 81681 | 81682 | 81683 | 103887 | 103888 | 103890 | 103899 | 103900 | 103901 | 103999 | 104000 | 104001 | 104002 | 104005 | 104006 | 104007 | 104066 | 104067 | 104068 | 104069 | 104070 | 104071 | 104246 | 104247 | 104248 | 104249 | 104250 | 104322 | 104323 | 104324 | 104325 | 104326 | 104327 | 104328 | 104329 | 104330 | 104331 | 104332 | 104333 | 104334 | 104335 | 104336 | 104391 | 104392 | 104393 | 104394 | 104395 | 104396 | 104397 | 104398 | 104474 | 104475 | 104476 | 104477 | 104478 | 104479 | 104480 | 104481 | 104545 | 104546 | 104547 | 104548 | 104549 | 104550 | 104551 | 104552 | 104646 | 104647 | 104648 | 104649 | 104650 | 104651 | 104652 | 104653 | 104722 | 104723 | 104724 | 104725 | 104726 | 104727 | 104728 | 104729 | 104806 | 104807 | 104808 | 104809 | 104810 | 104811 | 104812 | 104813 | 104814 | 104815 | 104816 | 104817 | 104818 | 104819 | 104820 | 104821 | 104863 | 104864 | 104865 | 104866 | 104867 | 104868 | 104869 | 104870 | 104902 | 104903 | 104904 | 104905 | 104906 | 104907 | 104908 | 104909 | 104910 | 104913 | 104914 | 104915 | 104916 | 104917 | 104918 | 104919 | 104920 | 104988 | 104989 | 104990 | 104991 | 104992 | 106268 | 106269 | 106371 | 106372 | 106373 | 106374 | 106375 | 106376 | 106377 | 106378 | 106810 | 106811 | 106812 | 106813 | 106814 | 106815 | 106816 | 106817 | 106857 | 107198 | 107199 | 107200 | 107201 | 107202 | 107203 | 107204 | 107205 | 107807 | 107808 | 107809 | 107810 | 107811 | 107812 | 107813 | 107814 | 107918 | 107919 | 107920 | 107921 | 107922 | 107923 | 107924 | 107925 | 108222 | 108223 | 108224 | 108225 | 108226 | 108227 | 108228 | 108229 | 108980 | 108981 | 108982 | 109306 | 109307 | 109308 | 109309 | 109310 | 109311 | 109312 | 109313 | 109314 | 109315 | 109316 | 109317 | 109318 | 109463 | 109464 | 109465 | 109466 | 109467 | 109468 | 109469 | 109775 | 109776 | 109777 | 109778 | 109779 | 109780 | 109781 | 109782 | 109783 | 109784 | 109785 | 111199 | 111200 | 111201 | 111202 | 111203 | 111204 | 111205 | 111206 | 112316 | 112317 | 112321 | 112322 | 112323 | 112324 | 112325 | 112326 | 112346 | 112472 | 112491 | 112540 | 112612 | 112613 | 112614 | 112615 | 112616 | 112617 | 112618 | 112619 | 112620 | 112621 | 112622 | 113195 | 113196 | 113197 | 113198 | 113199 | 113200 | 113201 | 113202 | 113203 | 113204 | 113205 | 113286 | 113287 | 113288 | 113289 | 113290 | 113291 | 113292 | 113293 | 113294 | 113295 | 113296 | 113297 | 113298 | 113335 | 113351 | 113352 | 113353 | 113354 | 113355 | 113356 | 113357 | 113358 | 113359 | 113361 | 113362 | 113363 | 113364 | 113365 | 113430 | 113431 | 113432 | 113433 | 113434 | 113435 | 113436 | 113437 | 113438 | 113439 | 113440 | 113441 | 113442 | 113443 | 113444 | 113445 | 116121 | 116122 | 116123 | 116124 | 116125 | 116126 | 116127 | 116128 | 116129 | 116130 | 116131 | 116132 | 116133 | 116134 | 118267 | 118268 | 118269 | 118270 | 118271 | 118272 | 118273 | 118274 | 118275 | 118276 | 118277 | 118278 | 118279 | 118280 | 122993 | 122994 | 122995 | 122996 | 122997 | 122998 | 122999 | 123000 | 123001 | 123002 | 123003 | 123004 | 123005 | 126244 | 126245 | 126246 | 126247 | 126248 | 126249 | 126250 | 126251 | 126252 | 126253 | 126254 | 126255 | 126256 | 126257 | 126453 | 126454 | 126455 | 126456 | 126457 | 126458 | 126459 | 126460 | 126469 | 126470 | 126565 | 126566 | 126568 | 126569 | 126570 | 126571 | 126572 | 126573 | 126574 | 126575 | 126576 | 126577 | 126578 | 126579 | 126580 | 129305 | 129306 | 129307 | 129308 | 129309 | 129310 | 129311 | 129312 | 129313 | 129314 | 129315 | 129316 | 129317 | 129318 | 129319 | 130641 | 130642 | 130643 | 130644 | 130645 | 130646 | 130647 | 130648 | 130649 | 130650 | 130651 | 130652 | 130653 | 130654 | 130655 | 130656 | 131108 | 131156 | 131157 | 131158 | 131159 | 131160 | 131193 | 131213 | 131257 | 131260 | 131261 | 131262 | 131263 | 131264 | 131265 | 131266 | 131267 | 131268 | 131269 | 131270 | 131271 | 131272 | 131273 | 131274 | 131275 | 131276 | 131277 | 131278 | 131279 | 131280 | 131281 | 131282 | 131330 | 131629 | 131630 | 131631 | 131664 | 131665 | 131666 | 131701 | 132332