Attachment 76887 Details for Bug 20811 – Bug 20811: Fix wrong usage of ModBiblio

[patch] Bug 20811: Fix wrong usage of ModBiblio

Bug-20811-Fix-wrong-usage-of-ModBiblio.patch (text/plain), 1.64 KB, created by Martin Renvoize (ashimema) on 2018-07-12 12:22:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2018-07-12 12:22:15 UTC

Size: 1.64 KB

patch

obsolete

>From e691175f9b3f7989d60d1f758df0776ac4896e50 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 28 May 2018 15:19:09 -0300
>Subject: [PATCH] Bug 20811: Fix wrong usage of ModBiblio
>
>Since
>  commit cefa7c21e28b88351ee8ae0dfefb80a515323df9
>  Bug 5635: bulkmarcimport new parameters & features
>
>AddBiblio call has been replaced with ModBiblio, but the return values
>are different. We should not replace the value of $biblionumber with
>what returns this subroutine.
>
>Test plan:
>If you are familiar with bulkmarcimport.pl you should know what to test,
>I am not.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> misc/migration_tools/bulkmarcimport.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl
>index 7a5a581a5e..46c501758a 100755
>--- a/misc/migration_tools/bulkmarcimport.pl
>+++ b/misc/migration_tools/bulkmarcimport.pl
>@@ -451,7 +451,7 @@ RECORD: while (  ) {
>                     $biblioitemnumber = Koha::Biblios->find( $biblionumber )->biblioitem->biblioitemnumber;
>                 };
>                 if ($update) {
>-                    eval { ( $biblionumber, $biblioitemnumber ) = ModBiblio( $record, $biblionumber, GetFrameworkCode($biblionumber) ) };
>+                    eval { ModBiblio( $record, $biblionumber, GetFrameworkCode($biblionumber) ) };
>                     if ($@) {
>                         warn "ERROR: Edit biblio $biblionumber failed: $@\n";
>                         printlog( { id => $id || $originalid || $biblionumber, op => "update", status => "ERROR" } ) if ($logfile);
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 20811: 75599 | 76861 | 76885 | 76886 | 76887 | 76888 | 76969 | 77154 | 77155 | 77156