Attachment 76888 Details for Bug 20811 – Bug 20811: Fix update flag in bulkmarcimport

[patch] Bug 20811: Fix update flag in bulkmarcimport

Bug-20811-Fix-update-flag-in-bulkmarcimport.patch (text/plain), 1.26 KB, created by Martin Renvoize (ashimema) on 2018-07-12 12:22:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2018-07-12 12:22:18 UTC

Size: 1.26 KB

patch

obsolete

>From 8d84c09b37fad012bc4e4235e8040ab8e7463e06 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 11 Jul 2018 11:06:18 -0300
>Subject: [PATCH] Bug 20811: Fix update flag in bulkmarcimport
>
>I have no idea why we have these two variables $id and $originalid, it
>seems that they should not cohabit.
>
>It feels like Users and original authors of this script should provide an
>update and refresh it.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> misc/migration_tools/bulkmarcimport.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl
>index 46c501758a..8efb7d6cc6 100755
>--- a/misc/migration_tools/bulkmarcimport.pl
>+++ b/misc/migration_tools/bulkmarcimport.pl
>@@ -427,7 +427,7 @@ RECORD: while (  ) {
>         }
>         else {
>             my ( $biblionumber, $biblioitemnumber, $itemnumbers_ref, $errors_ref );
>-            $biblionumber = $id;
>+            $biblionumber = $id || $originalid;
>             # check for duplicate, based on ISBN (skip it if we already have found a duplicate with match parameter
>             if (!$biblionumber && $isbn_check && $isbn) {
>     #         warn "search ISBN : $isbn";
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 20811: 75599 | 76861 | 76885 | 76886 | 76887 | 76888 | 76969 | 77154 | 77155 | 77156