Attachment 76892 Details for Bug 20079 – Bug 20079: Display stack trace for development installations

[patch] Bug 20079: Display stack trace for development installations

Bug-20079-Display-stack-trace-for-development-inst.patch (text/plain), 1.36 KB, created by Martin Renvoize (ashimema) on 2018-07-12 14:36:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2018-07-12 14:36:30 UTC

Size: 1.36 KB

patch

obsolete

>From c1affc7fdf2676e5d0a1e0b3ad7c185069dabd34 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 23 Jan 2018 15:54:41 -0300
>Subject: [PATCH] Bug 20079: Display stack trace for development installations
>
>"""The default value is development, which causes plackup to
>load the middleware components: AccessLog, StackTrace, and Lint unless
>--no-default-middleware is set."""
>
>Test plan:
>Confirm that the stack trace is displayed when something is wrong (die somewhere to test)
>for dev installations (inside a devbox)
>The -E flag must remain deployment for non-dev installs
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> debian/scripts/koha-plack | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/debian/scripts/koha-plack b/debian/scripts/koha-plack
>index 1677ee0ec1..68f899113b 100755
>--- a/debian/scripts/koha-plack
>+++ b/debian/scripts/koha-plack
>@@ -93,6 +93,11 @@ start_plack()
>              --error-log /var/log/koha/${instancename}/plack-error.log"
>     max_requests_and_workers="--max-requests ${PLACK_MAX_REQUESTS} --workers ${PLACK_WORKERS}"
> 
>+    if [ "$DEV_INSTALL" = "1" ]; then
>+        # Maybe we should switch off debug_mode if DEV_INSTALL is not set?
>+        environment="development"
>+    fi
>+
>     if [ "$debug_mode" = "yes" ]; then
>         environment="development"
>         daemonize=""
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 20079: 70860 | 70862 | 72341 | 76892