Bugzilla – Attachment 7702 Details for
Bug 7515
Authorized value code showing in OPAC for public note
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7515 - authorized value code showing in opac for public note
Bug-7515---authorized-value-code-showing-in-opac-f.patch (text/plain), 5.41 KB, created by
Kyle M Hall
on 2012-02-16 17:53:39 UTC
(
hide
)
Description:
Bug 7515 - authorized value code showing in opac for public note
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2012-02-16 17:53:39 UTC
Size:
5.41 KB
patch
obsolete
>From 4cc60220cbd31c7c76ad6f1f3d2449d68c97c6f7 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 14 Feb 2012 13:11:21 -0500 >Subject: [PATCH] Bug 7515 - authorized value code showing in opac for public note > >This alters C4::Items::GetItemsInfo() to look up the authorised value >for the itemnotes value if the field has been assigned an authorised >value rather than being a free text field. > >A new boolean parameter $opac has been added to let GetItemsInfo know if the >data is destined for the opac or intranet view. Defaults to intranet view. >--- > C4/Items.pm | 25 ++++++++++++++++++++++++- > opac/opac-ISBDdetail.pl | 2 +- > opac/opac-detail.pl | 4 ++-- > opac/opac-reserve.pl | 2 +- > opac/opac-sendbasket.pl | 2 +- > opac/opac-sendshelf.pl | 2 +- > 6 files changed, 30 insertions(+), 7 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index 04cb417..b3e6c08 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -1164,7 +1164,7 @@ If this is set, it is set to C<One Order>. > =cut > > sub GetItemsInfo { >- my ( $biblionumber ) = @_; >+ my ( $biblionumber, $opac ) = @_; > my $dbh = C4::Context->dbh; > # note biblioitems.* must be avoided to prevent large marc and marcxml fields from killing performance. > my $query = " >@@ -1269,6 +1269,29 @@ sub GetItemsInfo { > $data->{notforloanvalue} = $lib; > } > >+ # get itemnotes authorised value if applicable >+ my $sql_itemnotes = " >+ SELECT authorised_value >+ FROM marc_subfield_structure >+ WHERE kohafield = 'items.itemnotes' >+ AND frameworkcode = ? >+ "; >+ my $sth_itemnotes = $dbh->prepare( $sql_itemnotes ); >+ $sth_itemnotes->execute( $data->{'frameworkcode'} ); >+ >+ my ($authorised_valuecode) = $sth_itemnotes->fetchrow; >+ my $lib = $opac ? 'lib_opac' : 'lib'; >+ if ($authorised_valuecode) { >+ $sth_itemnotes = $dbh->prepare( >+ "SELECT $lib FROM authorised_values >+ WHERE category=? >+ AND authorised_value=?" >+ ); >+ $sth_itemnotes->execute( $authorised_valuecode, $data->{'itemnotes'} ); >+ my ($lib) = $sth_itemnotes->fetchrow; >+ $data->{'itemnotes'} = $lib; >+ } >+ > # get restricted status and description if applicable > my $restrictedstatus = $dbh->prepare( > 'SELECT authorised_value >diff --git a/opac/opac-ISBDdetail.pl b/opac/opac-ISBDdetail.pl >index 3373787..06021b3 100755 >--- a/opac/opac-ISBDdetail.pl >+++ b/opac/opac-ISBDdetail.pl >@@ -127,7 +127,7 @@ $template->param( > > my $norequests = 1; > my $res = GetISBDView($biblionumber, "opac"); >-my @items = GetItemsInfo( $biblionumber ); >+my @items = GetItemsInfo( $biblionumber, 1 ); > > my $itemtypes = GetItemTypes(); > for my $itm (@items) { >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index dd41bbb..22f637a 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -372,7 +372,7 @@ $template->param( 'ItemsIssued' => CountItemsIssued( $biblionumber ) ); > > $template->param('OPACShowCheckoutName' => C4::Context->preference("OPACShowCheckoutName") ); > # change back when ive fixed request.pl >-my @all_items = GetItemsInfo( $biblionumber ); >+my @all_items = GetItemsInfo( $biblionumber, 1 ); > > # adding items linked via host biblios > my $marcflavour = C4::Context->preference("marcflavour"); >@@ -386,7 +386,7 @@ if ($marcflavour eq 'MARC21' || $marcflavour eq 'NORMARC'){ > foreach my $hostfield ( $record->field($analyticfield)) { > my $hostbiblionumber = $hostfield->subfield("0"); > my $linkeditemnumber = $hostfield->subfield("9"); >- my @hostitemInfos = GetItemsInfo($hostbiblionumber); >+ my @hostitemInfos = GetItemsInfo( $hostbiblionumber, 1); > foreach my $hostitemInfo (@hostitemInfos){ > if ($hostitemInfo->{itemnumber} eq $linkeditemnumber){ > push(@all_items, $hostitemInfo); >diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl >index b2144a9..813c972 100755 >--- a/opac/opac-reserve.pl >+++ b/opac/opac-reserve.pl >@@ -123,7 +123,7 @@ foreach my $biblioNumber (@biblionumbers) { > my $biblioData = GetBiblioData($biblioNumber); > $biblioDataHash{$biblioNumber} = $biblioData; > >- my @itemInfos = GetItemsInfo($biblioNumber); >+ my @itemInfos = GetItemsInfo($biblioNumber,1); > > my $marcrecord= GetMarcBiblio($biblioNumber); > >diff --git a/opac/opac-sendbasket.pl b/opac/opac-sendbasket.pl >index 6a6e825..00a32e7 100755 >--- a/opac/opac-sendbasket.pl >+++ b/opac/opac-sendbasket.pl >@@ -81,7 +81,7 @@ if ( $email_add ) { > my $marcauthorsarray = GetMarcAuthors( $record, $marcflavour ); > my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour ); > >- my @items = GetItemsInfo( $biblionumber ); >+ my @items = GetItemsInfo( $biblionumber, 1 ); > > my $hasauthors = 0; > if($dat->{'author'} || @$marcauthorsarray) { >diff --git a/opac/opac-sendshelf.pl b/opac/opac-sendshelf.pl >index 6e60bc9..c92d6af 100755 >--- a/opac/opac-sendshelf.pl >+++ b/opac/opac-sendshelf.pl >@@ -89,7 +89,7 @@ if ( $email ) { > my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour ); > my $subtitle = GetRecordValue('subtitle', $record, $fw); > >- my @items = GetItemsInfo( $biblionumber ); >+ my @items = GetItemsInfo( $biblionumber, 1 ); > > $dat->{MARCNOTES} = $marcnotesarray; > $dat->{MARCSUBJCTS} = $marcsubjctsarray; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7515
:
7641
|
7643
|
7644
|
7702
|
7833
|
7893
|
7918
|
7924
|
8182
|
8214