Bugzilla – Attachment 77188 Details for
Bug 21103
Fix parameter reuse in Elasticsearch/QueryBuilder.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21103: Declare new parameter for loop iterator
Bug-21103-Declare-new-parameter-for-loop-iterator.patch (text/plain), 1.16 KB, created by
Nick Clemens (kidclamp)
on 2018-07-23 16:12:46 UTC
(
hide
)
Description:
Bug 21103: Declare new parameter for loop iterator
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2018-07-23 16:12:46 UTC
Size:
1.16 KB
patch
obsolete
>From 48ba29cc2edd67e89d6da912b1c132bd3c8ad187 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 23 Jul 2018 16:10:57 +0000 >Subject: [PATCH] Bug 21103: Declare new parameter for loop iterator > >To test: >prove -v t/00-testcritic.t >it fails >apply patch >it passes >--- > Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm >index 5d7136c..c746180 100644 >--- a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm >+++ b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm >@@ -315,8 +315,8 @@ sub build_authorities_query { > # regular wordlist stuff > # push @query_parts, { match => {$wh => { query => $val, operator => 'and' }} }; > my @values = split(' ',$val); >- foreach $val (@values) { >- push @query_parts, { wildcard => { "$wh.phrase" => "*" . lc $val . "*" } }; >+ foreach my $value (@values) { >+ push @query_parts, { wildcard => { "$wh.phrase" => "*" . lc $value . "*" } }; > } > } > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21103
: 77188