Attachment 77328 Details for Bug 19604 – Bug 19604: Fix perlcritic "Loop iterator is not lexical"

[patch] Bug 19604: Fix perlcritic "Loop iterator is not lexical"

Bug-19604-Fix-perlcritic-Loop-iterator-is-not-lexi.patch (text/plain), 1.20 KB, created by Jonathan Druart on 2018-07-31 11:22:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-07-31 11:22:01 UTC

Size: 1.20 KB

patch

obsolete

>From ea166481d6a9ab9a7b15ea32b659f40e1f34e817 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 31 Jul 2018 08:21:00 -0300
>Subject: [PATCH] Bug 19604: Fix perlcritic "Loop iterator is not lexical"
>
>Loop iterator is not lexical at line 318, column 13.  See page 108 of
>PBP.  (Severity: 5)
>---
> Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>index 5d7136ca6d..4e6a6e98b3 100644
>--- a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>+++ b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>@@ -315,8 +315,8 @@ sub build_authorities_query {
>             # regular wordlist stuff
> #            push @query_parts, { match => {$wh => { query => $val, operator => 'and' }} };
>             my @values = split(' ',$val);
>-            foreach $val (@values) {
>-                push @query_parts, { wildcard => { "$wh.phrase" => "*" . lc $val . "*" } };
>+            foreach my $v (@values) {
>+                push @query_parts, { wildcard => { "$wh.phrase" => "*" . lc $v . "*" } };
>             }
>         }
>     }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 19604: 69072 | 69198 | 69199 | 72807 | 72808 | 76977 | 76978 | 77088 | 77089 | 77328