Attachment 77329 Details for Bug 19166 – Bug 19166: Remove 'IF NOT EXISTS' in kohastructure

[patch] Bug 19166: Remove 'IF NOT EXISTS' in kohastructure

Bug-19166-Remove-IF-NOT-EXISTS-in-kohastructure.patch (text/plain), 1.35 KB, created by Jonathan Druart on 2018-07-31 11:31:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-07-31 11:31:52 UTC

Size: 1.35 KB

patch

obsolete

>From b1c77305215de6b69241bc991bc32525ab4dbb65 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 31 Jul 2018 08:30:53 -0300
>Subject: [PATCH] Bug 19166: Remove 'IF NOT EXISTS' in kohastructure
>
>The table is removed just before, this clause is useless.
>
>It also fixes a test:
>t/db_dependent/Creators/Lib.t .. 1/645
>  #   Failed test 'get_table_names return all tables matching'
>  #   at t/db_dependent/Creators/Lib.t line 1258.
>  #     Structures begin differing at:
>  #          $got->[10] = 'aqinvoice_adjustments'
>  #     $expected->[10] = 'aqinvoices'
>  # Looks like you failed 1 test of 645.
>---
> installer/data/mysql/kohastructure.sql | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index 81109a1520..bdec0ff2f2 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -3145,7 +3145,7 @@ CREATE TABLE aqinvoices (
> --
> 
> DROP TABLE IF EXISTS aqinvoice_adjustments;
>-CREATE TABLE IF NOT EXISTS aqinvoice_adjustments (
>+CREATE TABLE aqinvoice_adjustments (
>     adjustment_id int(11) NOT NULL AUTO_INCREMENT, -- primary key for adjustments
>     invoiceid int(11) NOT NULL, -- foreign key to link an adjustment to an invoice
>     adjustment decimal(28,6), -- amount of adjustment
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 19166: 66475 | 66476 | 67599 | 67600 | 67601 | 67602 | 67890 | 70413 | 70414 | 70415 | 70416 | 72702 | 72703 | 72704 | 72705 | 72744 | 72978 | 73481 | 73482 | 73483 | 73484 | 73485 | 73486 | 73487 | 74742 | 74743 | 74744 | 74745 | 74746 | 74747 | 74748 | 74843 | 74893 | 74894 | 74895 | 74896 | 74897 | 74898 | 74899 | 74900 | 75014 | 75043 | 76994 | 76995 | 76996 | 76997 | 76998 | 76999 | 77000 | 77001 | 77002 | 77003 | 77004 | 77104 | 77105 | 77106 | 77107 | 77108 | 77109 | 77110 | 77111 | 77112 | 77113 | 77114 | 77115 | 77116 | 77117 | 77118 | 77119 | 77120 | 77121 | 77122 | 77123 | 77124 | 77125 | 77126 | 77127 | 77128 | 77129 | 77130 | 77131 | 77132 | 77133 | 77134 | 77329