Attachment 77342 Details for Bug 21134 – Bug 21134: Correctly throw the exception in Koha::Patron::Modification->approve

[patch] Bug 21134: Correctly throw the exception in Koha::Patron::Modification->approve

Bug-21134-Correctly-throw-the-exception-in-KohaPat.patch (text/plain), 1.39 KB, created by Jonathan Druart on 2018-07-31 15:44:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-07-31 15:44:58 UTC

Size: 1.39 KB

patch

obsolete

>From 057c3919b168850c3c87cd7de7e7ab1391d33e94 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 31 Jul 2018 12:43:54 -0300
>Subject: [PATCH] Bug 21134: Correctly throw the exception in
> Koha::Patron::Modification->approve
>
>koha_1       |     # Looks like you planned 20 tests but ran 9.
>koha_1       |
>koha_1       | #   Failed test 'approve tests'
>koha_1       | #   at t/db_dependent/Koha/Patron/Modifications.t line
>259.
>koha_1       | [Something went wrong]# Looks like your test exited with
>255 just after 5.
>koha_1       | [21:13:47] t/db_dependent/Koha/Patron/Modifications.t
>.....................
>
>"Something went wrong" should never been thrown,
>Koha::Patron::Modification->approve raises $@, but it's not defined, it
>should raise $_ instead
>---
> Koha/Patron/Modification.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Patron/Modification.pm b/Koha/Patron/Modification.pm
>index 0fb1d0bbdc..b0e01b7378 100644
>--- a/Koha/Patron/Modification.pm
>+++ b/Koha/Patron/Modification.pm
>@@ -146,7 +146,7 @@ sub approve {
>                     Koha::Exceptions::Patron::Modification->throw( $_->{msg} );
>                 }
>                 else {
>-                    Koha::Exceptions::Patron::Modification->throw($@);
>+                    Koha::Exceptions::Patron::Modification->throw($_);
>                 }
>             };
>         }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21134: 77342 | 77343