Bugzilla – Attachment 77459 Details for
Bug 21141
Batch item modification tool throws error 500 when an itemnumber is invalid
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21151: Fix SRU search fields mapping pop-up
Bug-21151-Fix-SRU-search-fields-mapping-pop-up.patch (text/plain), 2.93 KB, created by
Katrin Fischer
on 2018-08-02 22:48:55 UTC
(
hide
)
Description:
Bug 21151: Fix SRU search fields mapping pop-up
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-08-02 22:48:55 UTC
Size:
2.93 KB
patch
obsolete
>From f8c1c6335ade301c42bbf2506ed0737faf388cec Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Wed, 1 Aug 2018 15:51:22 +0000 >Subject: [PATCH] Bug 21151: Fix SRU search fields mapping pop-up > >The SRU search fields mapping pop-up comes up as a blank white >page. > >To test: >- Go to Administration > Z39.50/SRU servers >- Modify or create an SRU server >- Click on the 'Modify' button to change mappings >- Verify the new window that opens is blank >- Apply patch >- Verify the pop-up now is no longer blank but works > correctly. > >Bonus: Spottd some HTML errors while looking for the > problem. Also fixed in the patch. > >https://bugs.koha-community.org/show_bug.cgi?id=21141 >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/sru_modmapping.tt | 3 ++- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt | 4 ++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/sru_modmapping.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/sru_modmapping.tt >index 341a703..f96c80e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/sru_modmapping.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/sru_modmapping.tt >@@ -2,7 +2,7 @@ > [% SET footerjs = 1 %] > [% INCLUDE 'doc-head-open.inc' %] > <title>Koha › SRU search fields mapping</title> >-[% INCLUDE 'doc-head-close.inc' %] >+[% INCLUDE 'doc-head-close.inc' popup => 1 %] > </head> > > <body id="admin_sru_modmapping" class="admin"> >@@ -70,6 +70,7 @@ > </fieldset> > </form> > </div> >+</div> > > [% MACRO jsinclude BLOCK %] > [% Asset.js("js/admin-menu.js") %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt >index 6af148e..b581b48 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt >@@ -130,7 +130,7 @@ > <div class="hint">Separate options by commas. Example: sru=get,sru_version=1.1. See also http://www.indexdata.com/yaz/doc/zoom.html.</div> > </li> > <li> >- <label for="sru_fields">SRU Search fields mapping: </label> >+ <label for="sru_fields">SRU search fields mapping: </label> > <input type="hidden" name="sru_fields" id="sru_fields" value="[% server.sru_fields %]" /> > <input type="text" name="show_sru_fields" id="show_sru_fields" size="100" value="[% server.sru_fields %]" disabled="disabled" /> <input type="button" id="modify_sru_fields" value="Modify" /> > </li> >@@ -138,7 +138,7 @@ > <li> > <label for="add_xslt">XSLT File(s) for transforming results: </label> > <input type="text" name="add_xslt" id="add_xslt" size="100" value="[% server.add_xslt %]"/> >- <div class="hint">Separate multiple filenames by commas.</span> >+ <div class="hint">Separate multiple filenames by commas.</div> > </li> > > </ol> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21141
:
77459
|
77497
|
77528
|
77554