Attachment 77472 Details for Bug 21033 – Bug 21033: Remove few warns in acqui/basket.pl

[patch] Bug 21033: Remove few warns in acqui/basket.pl

Bug-21033-Remove-few-warns-in-acquibasketpl.patch (text/plain), 1.79 KB, created by Jonathan Druart on 2018-08-03 14:31:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-08-03 14:31:02 UTC

Size: 1.79 KB

patch

obsolete

>From e441cf3bebb2658f452d500cc9a3fcd8b8e44cef Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Tue, 3 Jul 2018 15:52:05 +0200
>Subject: [PATCH] Bug 21033: Remove few warns in acqui/basket.pl
>
>Resolve (line numbers based on 16.11.x):
>Use of uninitialized value in hash element at acqui/basket.pl line 337.
>Use of uninitialized value in hash element at acqui/basket.pl line 338.
>Use of uninitialized value in hash element at acqui/basket.pl line 340.
>Use of uninitialized value in hash element at acqui/basket.pl line 342.
>Use of uninitialized value in hash element at acqui/basket.pl line 344.
>
>Argument "" isn't numeric in multiplication (*) at koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 486.
>Argument "" isn't numeric in multiplication (*) at koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 591.
>
>Test plan:
>If you have older acq data, you may have records in aqorders with field
>tax_rate_on_ordering is NULL. These orders will trigger the above warns.
>If you do not have, you could simulate by setting this field to NULL.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> acqui/basket.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/acqui/basket.pl b/acqui/basket.pl
>index 92fae60a0a..9f2ffdf7e1 100755
>--- a/acqui/basket.pl
>+++ b/acqui/basket.pl
>@@ -340,8 +340,8 @@ if ( $op eq 'list' ) {
>             $template->param( uncertainprices => 1 );
>         }
> 
>-        $line->{tax_rate} = $line->{tax_rate_on_ordering};
>-        $line->{tax_value} = $line->{tax_value_on_ordering};
>+        $line->{tax_rate} = $line->{tax_rate_on_ordering} // 0;
>+        $line->{tax_value} = $line->{tax_value_on_ordering} // 0;
> 
>         push @books_loop, $line;
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21033: 76652 | 76778 | 77418 | 77472