Attachment 7750 Details for Bug 7454 – Bug 7454 Initialize return arrays in ILS/Transaction/RenewAll

[patch] Bug 7454 Initialize return arrays in ILS/Transaction/RenewAll

Bug-7454-Initialize-return-arrays-in-ILSTransactio.patch (text/plain), 1.53 KB, created by Chris Cormack on 2012-02-19 06:51:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2012-02-19 06:51:09 UTC

Size: 1.53 KB

patch

obsolete

>From 53d40852d902911acd482264acd9bad50087b3ff Mon Sep 17 00:00:00 2001
>From: Colin Campbell <colin.campbell@ptfs-europe.com>
>Date: Tue, 17 Jan 2012 14:46:09 +0000
>Subject: [PATCH] Bug 7454 Initialize return arrays in
> ILS/Transaction/RenewAll
>
>Explicitly clear these arrays and update them directly.
>In practice item numbers were already in them when called
>so that more items were being returned than were actually
>renewed (or failed)
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>
>Functionally sound patch, and tested in production
>---
> C4/SIP/ILS/Transaction/RenewAll.pm |    6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/C4/SIP/ILS/Transaction/RenewAll.pm b/C4/SIP/ILS/Transaction/RenewAll.pm
>index a712806..2e49bf7 100644
>--- a/C4/SIP/ILS/Transaction/RenewAll.pm
>+++ b/C4/SIP/ILS/Transaction/RenewAll.pm
>@@ -38,6 +38,8 @@ sub do_renew_all {
> 	my $patron = $self->{patron};							# SIP's  patron
> 	my $borrower = GetMember('cardnumber'=>$patron->id);	# Koha's patron
> 	my $all_ok = 1;
>+    $self->{renewed} = [];
>+    $self->{unrenewed} = [];
> 	foreach my $itemx (@{$patron->{items}}) {
> 		my $item_id = $itemx->{barcode};
> 		my $item = new ILS::Item $item_id;
>@@ -52,9 +54,9 @@ sub do_renew_all {
> 		$self->do_renew_for($borrower);
> 		if ($self->ok) {
> 			$item->{due_date} = $self->{due};
>-			push @{$self->renewed  }, $item_id;
>+            push @{$self->{renewed}  }, $item_id;
> 		} else {
>-			push @{$self->unrenewed}, $item_id;
>+            push @{$self->{unrenewed}}, $item_id;
> 		}
> 	}
> 	$self->ok($all_ok);
>-- 
>1.7.5.4

Actions: View | Diff | Splinter Review

Attachments on bug 7454: 7256 | 7750