Attachment 7752 Details for Bug 7554 – Bug 7554: Clean newlines in browse script

[patch] Bug 7554: Clean newlines in browse script

Bug-7554-Clean-newlines-in-browse-script.patch (text/plain), 1.74 KB, created by Chris Cormack on 2012-02-19 06:59:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2012-02-19 06:59:28 UTC

Size: 1.74 KB

patch

obsolete

>From 1a2897ab78e78e698fac3896ab248486818eb2b8 Mon Sep 17 00:00:00 2001
>From: Jared Camins-Esakov <jcamins@cpbibliography.com>
>Date: Fri, 17 Feb 2012 12:50:47 -0500
>Subject: [PATCH] Bug 7554: Clean newlines in browse script
>
>Records with a newline in the title will break the Javascript search pagination
>on the OPAC without this patch.
>
>To test:
>1. Import a record with a newline in the title (an example is attached to this
>   bug)
>2. Do a search that turns up the record and at least one other
>3. View the detail page for one of the other records
>4. Observe that there is a javascript error
>5. Apply patch
>6. Repeat search
>7. Observe that there is no javascript error
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>
>Simple template change, works well
>---
> koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>index 5a2dc09..25480c8 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>@@ -8,7 +8,7 @@
>         var pag_index_ini = [% indexPag %];
>         [% IF ( listResults ) %]
>             [% FOREACH listResult IN listResults %]
>-                arrPagination[[% listResult.index %]] = {url:"[% listResult.url %]", title:"[% listResult.title|html %]", author:"[% listResult.author|html %]", biblionumber:[% listResult.biblionumber %]};
>+                arrPagination[[% listResult.index %]] = {url:"[% listResult.url %]", title:"[% listResult.title|remove('\n')|html %]", author:"[% listResult.author|html %]", biblionumber:[% listResult.biblionumber %]};
>            [% END %]
>         [% END %]
>     [% END %]
>-- 
>1.7.5.4

Actions: View | Diff | Splinter Review

Attachments on bug 7554: 7742 | 7743 | 7752 | 7774