Bugzilla – Attachment 77526 Details for
Bug 15408
Timestamp on funds not updated when you duplicate a budget
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Modified to run properly the QA tests
Modified-to-run-properly-the-QA-tests.patch (text/plain), 1.68 KB, created by
Nick Clemens (kidclamp)
on 2018-08-07 13:47:11 UTC
(
hide
)
Description:
Modified to run properly the QA tests
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2018-08-07 13:47:11 UTC
Size:
1.68 KB
patch
obsolete
>From a1bace8e55a92dbe08d7a314bf1a8287364c696f Mon Sep 17 00:00:00 2001 >From: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> >Date: Wed, 15 Feb 2017 08:43:51 +0000 >Subject: [PATCH] Modified to run properly the QA tests > >https://bugs.koha-community.org/show_bug.cgi?id=15408 > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > C4/Budgets.pm | 2 +- > t/db_dependent/Budgets.t | 5 +---- > 2 files changed, 2 insertions(+), 5 deletions(-) > >diff --git a/C4/Budgets.pm b/C4/Budgets.pm >index b352f50..caacd7c 100644 >--- a/C4/Budgets.pm >+++ b/C4/Budgets.pm >@@ -1221,7 +1221,7 @@ sub CloneBudgetHierarchy { > my $tidy_budget = > { map { join( ' ', @columns ) =~ /$_/ ? ( $_ => $budget->{$_} ) : () } > keys %$budget }; >- delete $tidy_budget->{timestamp}; >+ delete $tidy_budget->{timestamp}; > my $new_budget_id = AddBudget( > { > %$tidy_budget, >diff --git a/t/db_dependent/Budgets.t b/t/db_dependent/Budgets.t >index 1d9bcad..32e077d 100755 >--- a/t/db_dependent/Budgets.t >+++ b/t/db_dependent/Budgets.t >@@ -491,14 +491,11 @@ is($budget_period_cloned->{budget_period_description}, 'Budget Period Cloned', ' > > my $budget_cloned = C4::Budgets::GetBudgets({ budget_period_id => $budget_period_id_cloned }); > my $test = $budget_cloned->[0]->{timestamp}; >-warn $test; > my $budget_time = Koha::DateUtils::dt_from_string($test); > my $local_time = Koha::DateUtils::dt_from_string(); >-warn $budget_time; >-warn $local_time; > > >-is(DateTime::compare($budget_time, $local_time), 0); >+is(DateTime::compare($budget_time, $local_time), 0, "New budget got the right timestamp"); > > > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15408
:
59886
|
59887
|
59890
|
59974
|
60244
|
60337
|
60338
|
60339
|
62985
|
62986
|
62987
|
65181
|
65182
|
65183
|
77524
|
77525
|
77526
|
77527
|
77539
|
77540
|
77541
|
77542