Bugzilla – Attachment 77548 Details for
Bug 21173
Add hours as age unit to auto item modifications by age for damaged_on, itemlost_on and withdrawn_on fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21173 - Fixed 2 template and SQL typos
Bug-21173---Fixed-2-template-and-SQL-typos.patch (text/plain), 2.87 KB, created by
Alex Buckley
on 2018-08-08 03:33:25 UTC
(
hide
)
Description:
Bug 21173 - Fixed 2 template and SQL typos
Filename:
MIME Type:
Creator:
Alex Buckley
Created:
2018-08-08 03:33:25 UTC
Size:
2.87 KB
patch
obsolete
>From 383ecea0b2b3095b8a758a7a424aed7309dca273 Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Wed, 8 Aug 2018 15:31:08 +1200 >Subject: [PATCH] Bug 21173 - Fixed 2 template and SQL typos > >--- > C4/Items.pm | 6 +++--- > .../prog/en/modules/tools/automatic_item_modification_by_age.tt | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index 64a6b86..b867e5e 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -2839,15 +2839,15 @@ sub ToggleNewStatus { > if ( defined $age ) { > # Calculate item age based on hours since item last altered > if ( defined $rule && defined $age_starting_point && $unit eq "hours" && $age_starting_point eq "itemaltered" ) { >- $query .= q| AND HOUR(TIMEDIFF(NOW(), timestamp)) >= ? |; >+ $query .= q| AND HOUR(TIMEDIFF(NOW(), items.timestamp)) >= ? |; > push @params, $age; > } elsif ( defined $rule && defined $age_starting_point && $unit eq "days" && $age_starting_point eq "itemaltered" ) { > # Calculate item age based on days since item last altered >- $query .= q| AND TO_DAYS(NOW()) - TO_DAYS(timestamp) >= ? |; >+ $query .= q| AND TO_DAYS(NOW()) - TO_DAYS(items.timestamp) >= ? |; > push @params, $age; > } else { > # Calculate item age based on days since item was created >- $query .= q| AND TO_DAYS(NOW()) - TO_DAYS(dateaccessioned) >= ? |; >+ $query .= q| AND TO_DAYS(NOW()) - TO_DAYS(items.dateaccessioned) >= ? |; > push @params, $age; > } > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt >index 44cf3b1..cb4a5f7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt >@@ -163,7 +163,7 @@ > </div> > <div> > <h5>Unit</h5> >- <p>Note: If the unit of 'Hours' is set then you cannot choose an age starting point, the item age starting point wil default to the last item alteration event. The Age starting point selection will be hidden if you have set the unit to 'Hours'.</p> >+ <p>Note: If the unit of 'Hours' is set then you cannot choose an age starting point, the item age starting point will default to the last item alteration event. The Age starting point selection will be hidden if you have set the unit to 'Hours'.</p> > <select id="new_rule_unit" name="unit" /> > <option value="">Choose an age unit</option> > <option id="hours" value="hours">Hours</option> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21173
:
77547
|
77548
|
77604
|
77605
|
78917
|
79914
|
138870
|
138871
|
138872
|
138894
|
138895
|
138896
|
156137
|
156138
|
156139
|
158574
|
158575
|
160715
|
160716