Attachment 77583 Details for Bug 21182 – Bug 21182: Remove acqui/check_duplicate_barcode_ajax.pl

[patch] Bug 21182: Remove acqui/check_duplicate_barcode_ajax.pl

Bug-21182-Remove-acquicheckduplicatebarcodeajaxpl.patch (text/plain), 2.62 KB, created by Jonathan Druart on 2018-08-08 17:58:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-08-08 17:58:53 UTC

Size: 2.62 KB

patch

obsolete

>From 3508bcfd3deb440c7d46fc3eb47def31fc6ac809 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 6 Aug 2018 15:38:58 -0300
>Subject: [PATCH] Bug 21182: Remove acqui/check_duplicate_barcode_ajax.pl
>
>It has been added by
>  commit 327be442bd6e63e5ff8c0a5e2461ae836e8deffb
>  Bug 6963: Corrects a problem when a new order is created with a duplicate barcode.
>
>But its last call removed since:
>  commit eefc774e274ce8167f1063be5f9204a0d5cf5650
>  Bug 7178: Acquisition item creation improvement
>
>Test plan:
>  git grep check_duplicate_barcode
>should not return anything
>---
> acqui/check_duplicate_barcode_ajax.pl | 54 -----------------------------------
> 1 file changed, 54 deletions(-)
> delete mode 100755 acqui/check_duplicate_barcode_ajax.pl
>
>diff --git a/acqui/check_duplicate_barcode_ajax.pl b/acqui/check_duplicate_barcode_ajax.pl
>deleted file mode 100755
>index 0c283bc6fd..0000000000
>--- a/acqui/check_duplicate_barcode_ajax.pl
>+++ /dev/null
>@@ -1,54 +0,0 @@
>-#!/usr/bin/perl
>-
>-# FrÃ©dÃ©rick Capovilla, 2011 - LibÃ©o
>-#
>-# This file is part of Koha.
>-#
>-# Koha is free software; you can redistribute it and/or modify it
>-# under the terms of the GNU General Public License as published by
>-# the Free Software Foundation; either version 3 of the License, or
>-# (at your option) any later version.
>-#
>-# Koha is distributed in the hope that it will be useful, but
>-# WITHOUT ANY WARRANTY; without even the implied warranty of
>-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>-# GNU General Public License for more details.
>-#
>-# You should have received a copy of the GNU General Public License
>-# along with Koha; if not, see <http://www.gnu.org/licenses>.
>-
>-use Modern::Perl;
>-use CGI qw ( -utf8 );
>-use CGI::Cookie;
>-use JSON;
>-use C4::Auth;
>-use C4::Items;
>-use C4::Context;
>-
>-my $input        = new CGI;
>-print $input->header('application/json');
>-
>-# Check the user's permissions
>-my %cookies = CGI::Cookie->fetch;
>-my $sessid = $cookies{'CGISESSID'}->value || $input->param('CGISESSID');
>-my ($auth_status, $auth_sessid) = C4::Auth::check_cookie_auth($sessid, {acquisition => 'order_manage'});
>-if ($auth_status ne "ok") {
>-    print to_json({status => 'UNAUTHORIZED'});
>-    exit 0;
>-}
>-
>-my $json;
>-
>-#Check if the barcodes already exist.
>-my @barcodes = $input->multi_param('barcodes');
>-foreach my $barcode (@barcodes) {
>-    my $existing_itemnumber = GetItemnumberFromBarcode($barcode);
>-    if ($existing_itemnumber) {
>-        $json->{status} = "DUPLICATES";
>-        push @{$json->{barcodes}}, $barcode;
>-    }
>-}
>-
>-$json->{status} = 'OK' unless defined $json->{status};
>-print to_json($json);
>-
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21182: 77583 | 77629