Attachment 77724 Details for Bug 19500 – Bug 19500: Make module names on letters overview page translatable

[patch] Bug 19500: Make module names on letters overview page translatable

Bug-19500-Make-module-names-on-letters-overview-pa.patch (text/plain), 3.20 KB, created by Katrin Fischer on 2018-08-10 23:04:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2018-08-10 23:04:03 UTC

Size: 3.20 KB

patch

obsolete

>From 56dfb3841ec685be44f6f521adc89b3fdad330e5 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Fri, 10 Aug 2018 22:54:11 +0000
>Subject: [PATCH] Bug 19500: Make module names on letters overview page
> translatable
>
>While the module pull down on adding and editing a letter is
>written out and fully translatable, the overview page showed
>the internal 'module code'.
>
>Patch also renames the "Members" module into the "Patrons" module
>to match Koha's terminology.
>
>To test:
>- Before applying the patch:
>  - Add or edit a notice, look at the pull down for module
>  - Go back to the overview page
>  - Verify the module names don't match
>- Apply the patch:
>  - Check again, pull downs should now match
>  - Verify that Members is now Patrons everywhere
>---
> .../intranet-tmpl/prog/en/modules/tools/letter.tt    | 20 +++++++++++++++++---
> 1 file changed, 17 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>index 0e12c41..d3652c9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>@@ -92,7 +92,21 @@
>                 [% can_edit = lette.branchcode || !independant_branch %]
>                 <tr>
>                   <td>[% IF lette.branchname %][% lette.branchname %][% ELSE %](All libraries)[% END %]</td>
>-                  <td>[% lette.module %]</td>
>+                  <td>
>+                      [% SWITCH lette.module %]
>+                          [% CASE 'acquisition' %]Acquisition
>+                          [% CASE 'catalogue' %]Catalog
>+                          [% CASE 'circulation' %]Circulation
>+                          [% CASE 'orderacquisition' %]Order acquisition
>+                          [% CASE 'claimacquisition' %]Claim acquisition
>+                          [% CASE 'claimissues' %]Claim serial issue
>+                          [% CASE 'reserves' %]Holds
>+                          [% CASE 'members' %]Patrons
>+                          [% CASE 'serial' %]Serials (new issue)
>+                          [% CASE 'suggestions' %]Suggestions
>+                          [% CASE %][% lette.module %]
>+                      [% END %]
>+                  </td>
>                   <td>[% lette.code %]</td>
>                   <td>[% lette.name %]</td>
>                   <td class="actions">
>@@ -233,9 +247,9 @@
>                                       <option value="reserves">Holds</option>
>                                     [% END %]
>                                     [% IF ( module == "members" ) %]
>-                                      <option value="members" selected="selected">Members</option>
>+                                      <option value="members" selected="selected">Patrons</option>
>                                     [% ELSE %]
>-                                      <option value="members">Members</option>
>+                                      <option value="members">Patrons</option>
>                                     [% END %]
>                                     [% IF ( module == "serial" ) %]
>                                       <option value="serial" selected="selected">Serials (new issue)</option>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 19500: 77724 | 77815 | 77860 | 77987 | 77988 | 77989