Attachment 7774 Details for Bug 7554 – Signed patch

[patch] Signed patch

patch.txt (text/plain), 1.84 KB, created by Marcel de Rooy on 2012-02-20 13:35:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2012-02-20 13:35:04 UTC

Size: 1.84 KB

patch

obsolete

>From 4f5530eeab3c290d2c35180273e5c1b4723f4f0a Mon Sep 17 00:00:00 2001
>From: Jared Camins-Esakov <jcamins@cpbibliography.com>
>Date: Fri, 17 Feb 2012 12:50:47 -0500
>Subject: [PATCH] Bug 7554: Clean newlines in browse script
>Content-Type: text/plain; charset="utf-8"
>
>Records with a newline in the title will break the Javascript search pagination
>on the OPAC without this patch.
>
>To test:
>1. Import a record with a newline in the title (an example is attached to this
>   bug)
>2. Do a search that turns up the record and at least one other
>3. View the detail page for one of the other records
>4. Observe that there is a javascript error
>5. Apply patch
>6. Repeat search
>7. Observe that there is no javascript error
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>
>Simple template change, works well
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>index 5a2dc09..25480c8 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>@@ -8,7 +8,7 @@
>         var pag_index_ini = [% indexPag %];
>         [% IF ( listResults ) %]
>             [% FOREACH listResult IN listResults %]
>-                arrPagination[[% listResult.index %]] = {url:"[% listResult.url %]", title:"[% listResult.title|html %]", author:"[% listResult.author|html %]", biblionumber:[% listResult.biblionumber %]};
>+                arrPagination[[% listResult.index %]] = {url:"[% listResult.url %]", title:"[% listResult.title|remove('\n')|html %]", author:"[% listResult.author|html %]", biblionumber:[% listResult.biblionumber %]};
>            [% END %]
>         [% END %]
>     [% END %]
>-- 
>1.6.0.6
>

Actions: View | Diff | Splinter Review

Attachments on bug 7554: 7742 | 7743 | 7752 | 7774