Attachment 77933 Details for Bug 21183 – Bug 21183: Fix ->get_column call context

[patch] Bug 21183: Fix ->get_column call context

Bug-21183-Fix--getcolumn-call-context.patch (text/plain), 990 bytes, created by Jonathan Druart on 2018-08-16 15:12:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-08-16 15:12:42 UTC

Size: 990 bytes

patch

obsolete

>From 6a9e1d4215ab7b88144953690ece44a04cb8b0a3 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 16 Aug 2018 12:12:11 -0300
>Subject: [PATCH] Bug 21183: Fix ->get_column call context
>
>I am not sure to understand what's going on here.
>---
> tools/batchMod.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/tools/batchMod.pl b/tools/batchMod.pl
>index 3af72744eb..e50054cd4c 100755
>--- a/tools/batchMod.pl
>+++ b/tools/batchMod.pl
>@@ -266,7 +266,8 @@ if ($op eq "show"){
> 
>             my $existing_items = Koha::Items->search({ barcode => \@barcodelist });
>             @itemnumbers = $existing_items->get_column('itemnumber');
>-            my %exists = map {$_=>1} @{$existing_items->get_column('barcode')};
>+            my @barcodes = $existing_items->get_column('barcode');
>+            my %exists = map {$_=>1} @barcodes;
>             @notfoundbarcodes = grep { !$exists{$_} } @barcodelist;
>         }
>     }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21183: 77586 | 77587 | 77687 | 77930 | 77933 | 77936 | 77937 | 77938 | 78056 | 78057 | 78058