Attachment 77978 Details for Bug 21239 – Bug 21239: CSS regressions caused by SCSS move

[patch] Bug 21239: CSS regressions caused by SCSS move

Bug-21239-CSS-regressions-caused-by-SCSS-move.patch (text/plain), 2.24 KB, created by Owen Leonard on 2018-08-17 13:50:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2018-08-17 13:50:58 UTC

Size: 2.24 KB

patch

obsolete

>From 37ec0d5cf8205c6167eb55b393c907a9c2a86f3b Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 17 Aug 2018 12:47:52 +0000
>Subject: [PATCH] Bug 21239: CSS regressions caused by SCSS move
>
>This patch corrects some mistakes in staff-global.scss made during the
>conversion from CSS.
>
>To test, apply the patch and regenerate your CSS
>(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
>Clear your browser cache if necessary.
>
>View various forms in the staff client which have hints and required
>fields, including:
>
>- Notices & slips -> Modify notice
>- Administration -> Budgets -> Modify budget
>
>Verify that date format hints are positioned correctly. Try to submit
>the form with empty required fields and verify that the "This field is
>required" message is positioned correctly.
>---
> koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>index 695226d..ecb1af0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>@@ -899,7 +899,7 @@ fieldset {
>         border: 2px solid #B9D8D9;
> 
>         div {
>-            .hint {
>+            &.hint {
>                 margin-bottom: .4em;
>             }
>         }
>@@ -1014,9 +1014,9 @@ fieldset {
>         }
> 
>         div {
>-            .hint {
>+            &.hint {
>                 margin-bottom: .4em;
>-                margin-left: 7.5em;
>+                margin-left: 10.5em;
>             }
>         }
> 
>@@ -1027,7 +1027,7 @@ fieldset {
>             text-align: right;
>             width: 9em;
> 
>-            .error {
>+            &.error {
>                 float: none;
>                 margin-left: 1em;
>                 width: auto;
>@@ -1124,7 +1124,7 @@ fieldset {
>                 font-weight: bold;
>                 margin-right: 1em;
>                 text-align: right;
>-                width: 6em;
>+                width: 9em;
>             }
>         }
> 
>@@ -1171,7 +1171,7 @@ fieldset {
> 
> .yui-u {
>     div {
>-        .hint {
>+        &.hint {
>             margin-bottom: .4em;
>         }
>     }
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 21239: 77978 | 77985 | 78061 | 78102