Bugzilla – Attachment 77994 Details for
Bug 21242
Modification log redirects you to circulation with no borrower if 'Object' field is not populated with borrowernumber
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[ALTERNATIVE-PATCH] Bug 21242: Make object's input read-only when viewing patron's logs
Bug-21242-Make-objects-input-read-only-when-viewin.patch (text/plain), 2.31 KB, created by
Jonathan Druart
on 2018-08-17 17:44:01 UTC
(
hide
)
Description:
[ALTERNATIVE-PATCH] Bug 21242: Make object's input read-only when viewing patron's logs
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-08-17 17:44:01 UTC
Size:
2.31 KB
patch
obsolete
>From 93f33f5bd03fadfde1f0262401ff9dcaedab4e00 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 17 Aug 2018 14:43:38 -0300 >Subject: [PATCH] Bug 21242: Make object's input read-only when viewing > patron's logs > >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt | 8 ++++++-- > tools/viewlog.pl | 5 ----- > 2 files changed, 6 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt >index 2656d967e8..e6a3887d73 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt >@@ -131,7 +131,11 @@ > </li> > <li> > <label for="object">Object: </label> >- <input type="text" id="object" name="object" value="[% object | html %]" /> >+ [% IF patron %][%# From the members module %] >+ [% object | html %] ([% INCLUDE 'patron-title.inc' patron => patron %] ) >+ [% ELSE %] >+ <input type="text" id="object" name="object" value="[% object | html %]" /> >+ [% END %] > </li> > <li> > <label for="info">Info:</label> >@@ -276,7 +280,7 @@ > </div> > </div> > <div class="yui-b noprint"> >- [% IF ( circulation ) %] >+ [% IF patron %] > [% INCLUDE 'circ-menu.inc' %] > [% ELSE %] > [% IF ( CATALOGUING ) %] >diff --git a/tools/viewlog.pl b/tools/viewlog.pl >index 7c4384acb5..69bf3f2b6f 100755 >--- a/tools/viewlog.pl >+++ b/tools/viewlog.pl >@@ -73,10 +73,6 @@ if ( $src eq 'circ' ) { > use C4::Members::Attributes qw(GetBorrowerAttributes); > my $borrowernumber = $object; > my $patron = Koha::Patrons->find( $borrowernumber ); >- my $circ_info = 1; >- unless ( $patron ) { >- $circ_info = 0; >- } > if ( C4::Context->preference('ExtendedPatronAttributes') ) { > my $attributes = GetBorrowerAttributes( $borrowernumber ); > $template->param( >@@ -87,7 +83,6 @@ if ( $src eq 'circ' ) { > > $template->param( > patron => $patron, >- circulation => $circ_info, > ); > } > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21242
:
77975
|
77990
|
77994
|
81418