Bugzilla – Attachment 78006 Details for
Bug 21174
Change default behavior to open OPAC cart in one click
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21174 - Added missing atomicupdate
Bug-21174---Added-missing-atomicupdate.patch (text/plain), 2.38 KB, created by
Alex Buckley
on 2018-08-19 21:40:51 UTC
(
hide
)
Description:
Bug 21174 - Added missing atomicupdate
Filename:
MIME Type:
Creator:
Alex Buckley
Created:
2018-08-19 21:40:51 UTC
Size:
2.38 KB
patch
obsolete
>From 974c065d8f5e3ae4b5622e4e7049bc727a049e3d Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Mon, 20 Aug 2018 09:38:49 +1200 >Subject: [PATCH] Bug 21174 - Added missing atomicupdate > >Sponsored-By: Toi Ohomai Institute of Technology, New Zealand >--- > ...enabling_loading_of_cart_popup_on_one_click.sql | 1 + > koha-tmpl/opac-tmpl/bootstrap/js/basket.js | 22 ++++++---------------- > 2 files changed, 7 insertions(+), 16 deletions(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_21174_syspref_enabling_loading_of_cart_popup_on_one_click.sql > >diff --git a/installer/data/mysql/atomicupdate/bug_21174_syspref_enabling_loading_of_cart_popup_on_one_click.sql b/installer/data/mysql/atomicupdate/bug_21174_syspref_enabling_loading_of_cart_popup_on_one_click.sql >new file mode 100644 >index 0000000..ad572ec >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_21174_syspref_enabling_loading_of_cart_popup_on_one_click.sql >@@ -0,0 +1 @@ >+INSERT INTO systempreferences (variable, value, explanation) values ('EnableOneClickToOpenCartPopup' 0, 'Enable to load the cart popup immediately upon clicking on the OPAC cart icon'); >diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/basket.js b/koha-tmpl/opac-tmpl/bootstrap/js/basket.js >index 0d24d9e..52ea88a 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/js/basket.js >+++ b/koha-tmpl/opac-tmpl/bootstrap/js/basket.js >@@ -504,21 +504,11 @@ function updateAllLinks(target){ > } > > $("#cartDetails").ready(function(){ >- var cartprefenabled = document.getElementById("CartOneClick").value; >- if (cartprefenabled == "1") { >- $("#cartDetails,#cartmenulink").on("click",function(){ hideCart(); }); >- $("#cartmenulink").click(function(e){ >- e.preventDefault(); >- openBasket(); >- $("li").closest().removeClass("open"); >- }); >- } else { >- $("#cartDetails,#cartmenuitem,#cartmenulink").on("click",function(){ hideCart(); }); >- $("#cartmenuitem").click(function(e){ >- e.preventDefault(); >- openBasket(); >- $("li").closest().removeClass("open"); >- }); >- } >+ $("#cartDetails,#cartmenuitem,#cartmenulink").on("click",function(){ hideCart(); }); >+ $("#cartmenuitem").click(function(e){ >+ e.preventDefault(); >+ openBasket(); >+ $("li").closest().removeClass("open"); >+ }); > updateBasket(basketCount()); > }); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21174
:
77550
|
77642
|
77684
|
78006
|
78007
|
78008
|
78009
|
78010
|
79647
|
79714
|
79856
|
80293
|
80294
|
80295
|
80373
|
80374
|
80375