Attachment 78011 Details for Bug 21248 – Bug 21248: Fix COinS carp in MARC details page on unknown record

[patch] Bug 21248: Fix COinS carp in MARC details page on unknown record

0001-Bug-21248-Fix-COinS-carp-in-MARC-details-page-on-unk.patch (text/plain), 1.32 KB, created by paxed on 2018-08-20 04:34:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: paxed

Created: 2018-08-20 04:34:22 UTC

Size: 1.32 KB

patch

obsolete

>From 9ce10d688ab2d0740e7289e1406ed323e2ef9669 Mon Sep 17 00:00:00 2001
>From: Pasi Kallinen <pasi.kallinen@joensuu.fi>
>Date: Mon, 20 Aug 2018 07:30:45 +0300
>Subject: [PATCH] Bug 21248: Fix COinS carp in MARC details page on unknown
> record
>
>Looking up a nonexistent record in the MARC details -page causes
>the COinS to carp. The fix is trivial, just move the COinS call
>couple lines, after the record existence check.
>
>Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>
>---
> catalogue/MARCdetail.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/catalogue/MARCdetail.pl b/catalogue/MARCdetail.pl
>index 8940471456..b4adcfdeea 100755
>--- a/catalogue/MARCdetail.pl
>+++ b/catalogue/MARCdetail.pl
>@@ -90,7 +90,6 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
> my $record = GetMarcBiblio({
>     biblionumber => $biblionumber,
>     embed_items  => 1 });
>-$template->param( ocoins => GetCOinSBiblio($record) );
> 
> if ( not defined $record ) {
>     # biblionumber invalid -> report and exit
>@@ -101,6 +100,8 @@ if ( not defined $record ) {
>     exit;
> }
> 
>+$template->param( ocoins => GetCOinSBiblio($record) );
>+
> my $biblio_object = Koha::Biblios->find( $biblionumber ); # FIXME Should replace $biblio
> my $tagslib = &GetMarcStructure(1,$frameworkcode);
> my $biblio = GetBiblioData($biblionumber);
>-- 
>2.11.0
>

Actions: View | Diff | Splinter Review

Attachments on bug 21248: 78011 | 78451 | 78644